refactor(api): extract VariantAutoscalingConfigSpec for higher-level controller integration (#830)

Signed-off-by: Vivek Karunai Kiri Ragavan <vkarunai@redhat.com>

Author: vivekk16

api/v1alpha1/variantautoscaling_types.go

@@ -5,6 +5,17 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
+// VariantAutoscalingConfigSpec holds the optional tuning fields for a VariantAutoscaling.
+// It is extracted as a standalone embeddable type so that higher-level controllers
+// (e.g. KServe) can inline it without duplicating field definitions.
+type VariantAutoscalingConfigSpec struct {
+	// VariantCost specifies the cost per replica for this variant (used in saturation analysis).
+	// +kubebuilder:validation:Optional
+	// +kubebuilder:validation:Pattern=`^\d+(\.\d+)?$`
+	// +kubebuilder:default="10.0"
+	VariantCost string `json:"variantCost,omitempty"`
+}
+
 // VariantAutoscalingSpec defines the desired state for autoscaling a model variant.
 type VariantAutoscalingSpec struct {
 	// ScaleTargetRef references the scalable resource to manage.
@@ -17,11 +28,8 @@ type VariantAutoscalingSpec struct {
 	// +kubebuilder:validation:Required
 	ModelID string `json:"modelID"`
 
-	// VariantCost specifies the cost per replica for this variant (used in saturation analysis).
-	// +kubebuilder:validation:Optional
-	// +kubebuilder:validation:Pattern=`^\d+(\.\d+)?$`
-	// +kubebuilder:default="10.0"
-	VariantCost string `json:"variantCost,omitempty"`
+	// VariantAutoscalingConfigSpec holds optional tuning fields that integrators can embed.
+	VariantAutoscalingConfigSpec `json:",inline"`
 }
 
 // VariantAutoscalingStatus represents the current status of autoscaling for a variant,

api/v1alpha1/zz_generated.deepcopy.go

@@ -111,8 +111,10 @@ func buildVariantAutoscaling(namespace, name, deploymentName, modelID, accelerat
 				Kind:       "Deployment",
 				Name:       deploymentName,
 			},
-			ModelID:     modelID,
-			VariantCost: fmt.Sprintf("%.1f", cost),
+			ModelID: modelID,
+			VariantAutoscalingConfigSpec: variantautoscalingv1alpha1.VariantAutoscalingConfigSpec{
+				VariantCost: fmt.Sprintf("%.1f", cost),
+			},
 		},
 	}
 }

test/e2e/fixtures/va_builder.go

@@ -881,8 +881,10 @@ func CreateVariantAutoscalingResource(namespace, resourceName, scaleTargetRefNam
 				Kind:       "Deployment",
 				Name:       scaleTargetRefName,
 			},
-			ModelID:     modelId,
-			VariantCost: fmt.Sprintf("%.1f", variantCost),
+			ModelID: modelId,
+			VariantAutoscalingConfigSpec: v1alpha1.VariantAutoscalingConfigSpec{
+				VariantCost: fmt.Sprintf("%.1f", variantCost),
+			},
 		},
 	}
 }