Skip to content

Commit ccd1a8b

Browse files
committed
skip modelservice install for e2es
Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
1 parent 5db11aa commit ccd1a8b

2 files changed

Lines changed: 31 additions & 3 deletions

File tree

deploy/kind-emulator/install.sh

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,13 @@ source "${_wva_deploy_lib}/kube_like_adapter.sh"
219219
# Apply llm-d infrastructure fixes for Kind emulated clusters - e.g., remove prefill deployments, remove decode deployments if tests are enabled
220220
apply_llm_d_infrastructure_fixes() {
221221
log_info "Applying llm-d infrastructure fixes for KIND emulator..."
222+
# Skip cleanup when modelservice release is not installed (e.g., e2e infra-only
223+
# path now excludes it via helmfile selector).
224+
if ! helm list -n "$LLMD_NS" --short 2>/dev/null | grep -q '^ms-'; then
225+
log_info "No llm-d modelservice release detected in $LLMD_NS; skipping prefill/decode cleanup"
226+
return
227+
fi
228+
222229
# Delete prefill deployment
223230
# TODO: remove once WVA supports both prefill and decode
224231
log_info "Deleting prefill deployments..."

deploy/lib/infra_llmd.sh

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -369,12 +369,33 @@ deploy_llm_d_infrastructure() {
369369
# separately using the local chart (supports dev/test of chart changes).
370370
# The helmfile's WVA release uses the published OCI chart which may not
371371
# have the latest fixes and uses KIND-specific defaults (e.g. monitoringNamespace).
372-
local helmfile_selector=""
372+
local -a helmfile_selector_exprs=()
373373
if [ "$DEPLOY_WVA" == "true" ]; then
374-
helmfile_selector="--selector kind!=autoscaling"
374+
helmfile_selector_exprs+=("kind!=autoscaling")
375375
log_info "Skipping WVA in helmfile (will be deployed separately from local chart)"
376376
fi
377-
helmfile apply -e $GATEWAY_PROVIDER -n ${LLMD_NS} $helmfile_selector
377+
if [ "$E2E_TESTS_ENABLED" = "true" ] && [ "$INFRA_ONLY" = "true" ]; then
378+
# E2E infra-only tests create scenario-specific modelservice workloads
379+
# themselves. Skip the default llm-d-modelservice release so baseline
380+
# infrastructure is clean and we avoid create-then-delete churn.
381+
helmfile_selector_exprs+=("chart!=llm-d-modelservice")
382+
log_info "E2E infra-only mode: skipping llm-d-modelservice release in helmfile"
383+
fi
384+
local selector_csv=""
385+
if [ "${#helmfile_selector_exprs[@]}" -gt 0 ]; then
386+
selector_csv=$(IFS=,; echo "${helmfile_selector_exprs[*]}")
387+
log_info "helmfile selector: $selector_csv"
388+
helmfile apply -e "$GATEWAY_PROVIDER" -n "${LLMD_NS}" --selector "$selector_csv"
389+
else
390+
log_info "helmfile selector: (none)"
391+
helmfile apply -e "$GATEWAY_PROVIDER" -n "${LLMD_NS}"
392+
fi
393+
394+
if [ "$E2E_TESTS_ENABLED" = "true" ] && [ "$INFRA_ONLY" = "true" ]; then
395+
if helm list -n "$LLMD_NS" --short 2>/dev/null | grep -q '^ms-'; then
396+
log_warning "Modelservice release still present in $LLMD_NS despite e2e selector; tests may need extra cleanup"
397+
fi
398+
fi
378399

379400
# Post-deploy: align the WVA vllm-service selector and ServiceMonitor to match
380401
# the actual pod labels. The llm-d-modelservice chart sets pod labels from

0 commit comments

Comments
 (0)