Skip to content

Commit ef6f0cf

Browse files
authored
Fixes for infra install (#998)
* fixes for infra install * address review
1 parent ee31e48 commit ef6f0cf

2 files changed

Lines changed: 14 additions & 0 deletions

File tree

Makefile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,8 @@ deploy-e2e-infra: ## Deploy e2e test infrastructure (infra-only: WVA + llm-d, no
194194
SCALER_BACKEND=$(SCALER_BACKEND) \
195195
INSTALL_GATEWAY_CTRLPLANE=true \
196196
NAMESPACE_SCOPED=false \
197+
DECODE_REPLICAS=$(DECODE_REPLICAS) \
198+
LLM_D_RELEASE=$(LLM_D_RELEASE) \
197199
WVA_IMAGE_REPO=$$IMAGE_REPO \
198200
WVA_IMAGE_TAG=$$IMAGE_TAG \
199201
WVA_IMAGE_PULL_POLICY=IfNotPresent \
@@ -207,6 +209,8 @@ deploy-e2e-infra: ## Deploy e2e test infrastructure (infra-only: WVA + llm-d, no
207209
SCALER_BACKEND=$(SCALER_BACKEND) \
208210
INSTALL_GATEWAY_CTRLPLANE=true \
209211
NAMESPACE_SCOPED=false \
212+
DECODE_REPLICAS=$(DECODE_REPLICAS) \
213+
LLM_D_RELEASE=$(LLM_D_RELEASE) \
210214
./deploy/install.sh; \
211215
fi
212216

deploy/lib/infra_llmd.sh

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,16 @@ deploy_llm_d_infrastructure() {
202202
helmfile apply -e "$GATEWAY_PROVIDER" -n "${LLMD_NS}"
203203
fi
204204

205+
# Post-deploy workaround: Upstream EPP chart (v1.0.1) is missing RBAC for inferencemodelrewrites
206+
log_info "Patching Role $LLM_D_EPP_NAME to include inferencemodelrewrites"
207+
if kubectl get role "$LLM_D_EPP_NAME" -n "$LLMD_NS" &> /dev/null; then
208+
kubectl patch role "$LLM_D_EPP_NAME" -n "$LLMD_NS" --type='json' -p='[{"op": "add", "path": "/rules/0/resources/-", "value": "inferencemodelrewrites"}]' && \
209+
log_success "Patched Role $LLM_D_EPP_NAME successfully" || \
210+
log_warning "Failed to patch Role $LLM_D_EPP_NAME"
211+
else
212+
log_warning "Role $LLM_D_EPP_NAME not found, skipping RBAC patch"
213+
fi
214+
205215
if [ "$E2E_TESTS_ENABLED" = "true" ] && [ "$INFRA_ONLY" = "true" ]; then
206216
if helm list -n "$LLMD_NS" --short 2>/dev/null | grep -q '^ms-'; then
207217
log_warning "Modelservice release still present in $LLMD_NS despite e2e selector; tests may need extra cleanup"

0 commit comments

Comments
 (0)