Skip to content

opt in for keda, env specific#967

Merged
mamy-CS merged 2 commits intollm-d:mainfrom
mamy-CS:nightly-fix
Apr 2, 2026
Merged

opt in for keda, env specific#967
mamy-CS merged 2 commits intollm-d:mainfrom
mamy-CS:nightly-fix

Conversation

@mamy-CS
Copy link
Copy Markdown
Collaborator

@mamy-CS mamy-CS commented Apr 2, 2026

treat KEDA as already provided by the cluster on generic Kubernetes and openshift, and only verify it’s there instead of installing it by default.
Opt-in: use an env flag when you want the script to install or upgrade KEDA with Helm

@mamy-CS mamy-CS requested a review from clubanderson April 2, 2026 17:13
@mamy-CS mamy-CS enabled auto-merge (squash) April 2, 2026 17:14
@mamy-CS
Copy link
Copy Markdown
Collaborator Author

mamy-CS commented Apr 2, 2026

/ok-to-test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

🚀 Kind E2E (full) triggered by /ok-to-test

View the Kind E2E workflow run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

🚀 OpenShift E2E — approve and run (/ok-to-test)

View the OpenShift E2E workflow run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

GPU Pre-flight Check ✅

GPUs are available for e2e-openshift tests. Proceeding with deployment.

Resource Total Allocated Available
GPUs 50 34 16
Cluster Value
Nodes 16 (7 with GPUs)
Total CPU 993 cores
Total Memory 10383 Gi
GPUs required 4 (min) / 6 (recommended)

Copy link
Copy Markdown
Contributor

@clubanderson clubanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while I think this might help, its probably not all that is broken.

I suggest the team, at large, look at the public data available in the failed runs for the past 4 weeks for the WVA on OCP and CKS to get a more holistic understanding of what is broken.

I could just approve this, but it won't get you a fully operational nightly test - your choice - just let me know if you want me to just approve this.

@clubanderson
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@github-actions github-actions bot added the lgtm Looks good to me, indicates that a PR is ready to be merged. label Apr 2, 2026
github-actions[bot]
github-actions bot previously approved these changes Apr 2, 2026
@clubanderson clubanderson added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2026
@mamy-CS
Copy link
Copy Markdown
Collaborator Author

mamy-CS commented Apr 2, 2026

/ok-to-test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

🚀 Kind E2E (full) triggered by /ok-to-test

View the Kind E2E workflow run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

🚀 OpenShift E2E — approve and run (/ok-to-test)

View the OpenShift E2E workflow run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

GPU Pre-flight Check ✅

GPUs are available for e2e-openshift tests. Proceeding with deployment.

Resource Total Allocated Available
GPUs 50 32 18
Cluster Value
Nodes 16 (7 with GPUs)
Total CPU 993 cores
Total Memory 10383 Gi
GPUs required 4 (min) / 6 (recommended)

Comment thread test/e2e/config.go Outdated
mamy-CS added 2 commits April 2, 2026 15:54
Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
Made-with: Cursor
Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
Made-with: Cursor
@mamy-CS
Copy link
Copy Markdown
Collaborator Author

mamy-CS commented Apr 2, 2026

/ok-to-test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

🚀 Kind E2E (full) triggered by /ok-to-test

View the Kind E2E workflow run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

🚀 OpenShift E2E — approve and run (/ok-to-test)

View the OpenShift E2E workflow run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

GPU Pre-flight Check ✅

GPUs are available for e2e-openshift tests. Proceeding with deployment.

Resource Total Allocated Available
GPUs 50 32 18
Cluster Value
Nodes 16 (7 with GPUs)
Total CPU 993 cores
Total Memory 10383 Gi
GPUs required 4 (min) / 6 (recommended)

@asm582
Copy link
Copy Markdown
Collaborator

asm582 commented Apr 2, 2026

/lgtm
/approve

@mamy-CS mamy-CS merged commit 0ee5ba1 into llm-d:main Apr 2, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Looks good to me, indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants