Skip to content

Commit e899a48

Browse files
authored
Some perf_topdown code cleanup (#714)
* topdown: remove unneccessary data structure * topdown: Remove example CMakeLists comments
1 parent 74e4865 commit e899a48

2 files changed

Lines changed: 0 additions & 27 deletions

File tree

src/services/perf/CMakeLists.txt

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,2 @@
1-
# Use the add_service_sources() macro to add sources without external dependencies.
2-
# For services that do have external dependencies (a third-party library), create
3-
# an object library instead and use the add_service_objectlib macro instead:
4-
#
5-
# include_directories(${<dependency>_INCLUDE_DIRS})
6-
# add_library(caliper-templateservices OBJECT ${CALIPER_SERVICE_TEMPLATE_SOURCES})
7-
#
8-
# add_service_objlib("caliper-templateservices")
91
add_service_sources(PerfTopdown.cpp)
10-
11-
# Use the add_caliper_service() macro to add the service(s).
12-
# The first word in the string must be the name used in the service's
13-
# CaliperService variable name and name element. The second (optional) word
14-
# is a #ifdef condition in caliper-config.h that must be met for the
15-
# service.
162
add_caliper_service("perf_topdown CALIPER_HAVE_LIBPFM")

src/services/perf/PerfTopdown.cpp

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -78,19 +78,6 @@ bool check_compatibility()
7878

7979
class PerfTopdownService
8080
{
81-
struct topdown_record_t {
82-
uint64_t num { 0 };
83-
uint64_t slots { 0 };
84-
uint64_t retiring { 0 };
85-
uint64_t bad_spec { 0 };
86-
uint64_t fe_bound { 0 };
87-
uint64_t be_bound { 0 };
88-
uint64_t heavy_ops { 0 };
89-
uint64_t br_mispred { 0 };
90-
uint64_t fetch_lat { 0 };
91-
uint64_t mem_bound { 0 };
92-
};
93-
9481
enum Level { Top, All };
9582

9683
struct ThreadInfo {

0 commit comments

Comments
 (0)