Skip to content

Commit f2de290

Browse files
authored
hotfix v2023.03.2 (#229)
* Extra rpaths. * find file behaviour switch for cmake 3.21+. * 2023.03.2 release notes. * docs version.
1 parent 72eff64 commit f2de290

5 files changed

Lines changed: 23 additions & 7 deletions

File tree

RELEASE_NOTES.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
Version v2023.03.2 -- Release date 2023-07-03
2+
=============================================
3+
4+
This is a patch release. It brings in further TOSS4 related fixes.
5+
6+
Note:
7+
This release fails to install py-scipy spack dependency for clang v14.0.6, LC release builds are installed w/ gcc.
8+
The clang spack build will not be fixed for this patch release.
9+
110
Version v2023.03.1 -- Release date 2023-06-20
211
=============================================
312

cmake/spheral/SpheralAddLibs.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ function(spheral_add_cxx_library
113113

114114
# Set the r-path of the C++ lib such that it is independent of the build dir when installed
115115
set_target_properties(Spheral_${package_name} PROPERTIES
116-
INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/lib;${conduit_DIR}/lib;${axom_DIR}/lib;${boost_DIR}/lib;${hdf5_DIR}/lib"
116+
INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/lib;${conduit_DIR}/lib;${axom_DIR}/lib;${boost_DIR}/lib;${hdf5_DIR}/lib;${EXTRA_RPATHS}"
117117
)
118118
endfunction()
119119

@@ -161,7 +161,7 @@ function(spheral_add_pybind11_library package_name)
161161

162162
# Set the r-path of the C++ lib such that it is independent of the build dir when installed
163163
set_target_properties(${MODULE_NAME} PROPERTIES
164-
INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/lib;${conduit_DIR}/lib;${axom_DIR}/lib;${boost_DIR}/lib;${python_DIR}/lib;${hdf5_DIR}/lib"
164+
INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/lib;${conduit_DIR}/lib;${axom_DIR}/lib;${boost_DIR}/lib;${python_DIR}/lib;${hdf5_DIR}/lib;${EXTRA_RPATHS}"
165165
)
166166

167167
endfunction()

cmake/spheral/SpheralHandleTPL.cmake

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,14 @@ function(Spheral_Handle_TPL lib_name dep_list target_type)
9090
else()
9191
message("Found: ${temp_abs_path}")
9292
endif()
93-
unset(temp_abs_path CACHE) # Remove this line when using cmake 3.21+, same as find_file(NO_CACHE)
93+
94+
# find_file treats output as a standard variable from 3.21+ We get different behavior on later CMake versions.
95+
if(${CMAKE_VERSION} VERSION_LESS "3.21.0")
96+
unset(temp_abs_path CACHE)
97+
else()
98+
unset(temp_abs_path)
99+
endif()
100+
94101
endforeach()
95102

96103
# Register any libs/includes under a blt dir for later use/depends

docs/conf.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@
2626
author = u'J. Michael Owen'
2727

2828
# The short X.Y version
29-
version = u'2022.06.0'
29+
version = u'2023.03.2'
3030
# The full version, including alpha/beta/rc tags
31-
release = u'2022.06.0'
31+
release = u'2023.03.2'
3232

3333

3434
# -- General configuration ---------------------------------------------------

docs/conf.py.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ copyright = u'2012, LLNS'
2626
author = u'J. Michael Owen'
2727

2828
# The short X.Y version
29-
version = u'1.0'
29+
version = u'2023.03.2'
3030
# The full version, including alpha/beta/rc tags
31-
release = u'2022.6.1'
31+
release = u'2023.03.2'
3232

3333

3434
# -- General configuration ---------------------------------------------------

0 commit comments

Comments
 (0)