rework packaging for shared library with python library

Author: phlptp

.github/workflows/pip.yml

@@ -35,7 +35,7 @@ jobs:
       run: python -m pytest ./test/python
 
   build_shared:
-    name: Build with Pip
+    name: Build with Pip shared lib
     runs-on: ${{ matrix.platform }}
     strategy:
       fail-fast: false
@@ -46,6 +46,40 @@ jobs:
     steps:
     - uses: actions/checkout@v4
 
+    - uses: actions/setup-python@v5
+      with:
+        python-version: ${{ matrix.python-version }}
+
+    - name: Set min macOS version
+      if: runner.os == 'macOS'
+      run: |
+        echo "MACOSX_DEPLOYMENT_TARGET=11.0" >> $GITHUB_ENV
+
+    - name: Build and install
+      run: |
+        mkdir -p build
+        cd build
+        cmake .. -DUNITS_BUILD_SHARED_LIBRARY=ON -DUNITS_BUILD_STATIC_LIBRARY=OFF -DUNITS_INSTALL=ON
+        make -j 4
+        make install
+        python -m pip install pytest
+        pip install -vv -C cmake.define.UNITS_BUILD_SHARED_LIBRARY:BOOL=ON -C cmake.define.UNITS_BUILD_STATIC_LIBRARY:BOOL=OFF .
+
+    - name: Test
+      run: python -m pytest ./test/python
+
+  build_shared_windows:
+    name: Build with Pip shared lib
+    runs-on: ${{ matrix.platform }}
+    strategy:
+      fail-fast: false
+      matrix:
+        platform: [windows-latest]
+        python-version: ["3.11", "3.13"]
+
+    steps:
+    - uses: actions/checkout@v4
+
     - uses: actions/setup-python@v5
       with:
         python-version: ${{ matrix.python-version }}
@@ -58,7 +92,7 @@ jobs:
     - name: Build and install
       run: |
         python -m pip install pytest
-        pip install -vv -C cmake.define.UNITS_BUILD_SHARED_LIBRARY:BOOL=ON .
+        pip install -vv -C cmake.define.UNITS_BUILD_SHARED_LIBRARY:BOOL=ON -C cmake.define.UNITS_BUILD_STATIC_LIBRARY:BOOL=OFF -C cmake.define.UNITS_PYTHON_INSTALL_SHARED_LIBRARY:BOOL=ON .
 
     - name: Test
       run: python -m pytest ./test/python

CMakeLists.txt

@@ -266,7 +266,7 @@ if(NOT UNITS_HEADER_ONLY AND UNITS_BUILD_PYTHON_LIBRARY)
 
     # Install directive for scikit-build-core
     install(TARGETS units_llnl_ext LIBRARY DESTINATION units_llnl)
-    if(UNITS_BUILD_SHARED_LIBRARY)
+    if(UNITS_BUILD_SHARED_LIBRARY AND UNITS_PYTHON_INSTALL_SHARED_LIBRARY)
 
         # -------------------------------------------------------------
         # setting the RPATH
@@ -283,7 +283,7 @@ if(NOT UNITS_HEADER_ONLY AND UNITS_BUILD_PYTHON_LIBRARY)
 
         # Add the local directory to the rpath
         if(NOT APPLE)
-            list(APPEND CMAKE_INSTALL_RPATH $ORIGIN)
+            list(APPEND CMAKE_INSTALL_RPATH "$ORIGIN")
         else()
             list(APPEND CMAKE_INSTALL_RPATH "@loader_path")
             list(APPEND CMAKE_INSTALL_RPATH "@executable_path")