Tests adjusted

Author: lloc

.phpcs.xml.dist

@@ -2,8 +2,12 @@
 <ruleset name="CS">
     <description>PHPCS MslsMenu configuration</description>
     <config name="testVersion" value="7.4-"/>
+
+    <file>MslsMenu.php</file>
+    <file>tests/</file>
+
     <exclude-pattern>bin/*</exclude-pattern>
-    <exclude-pattern>tests/*</exclude-pattern>
+    <exclude-pattern>node_modules/*</exclude-pattern>
     <exclude-pattern>vendor/*</exclude-pattern>
 
     <arg value="ps"/>
@@ -13,14 +17,30 @@
     <arg name="cache" value=".phpcs.cache"/>
 
     <rule ref="WordPress">
+        <!-- PSR4 -->
         <exclude name="Generic.Commenting.DocComment.MissingShort" />
         <exclude name="Squiz.Commenting.FileComment.Missing" />
         <exclude name="Squiz.Commenting.ClassComment.Missing" />
         <exclude name="Squiz.Commenting.FunctionComment.Missing" />
         <exclude name="Squiz.Commenting.FunctionComment.MissingParamComment" />
         <exclude name="WordPress.Files.FileName" />
-        <exclude name="Generic.CodeAnalysis.UnusedFunctionParameter.Found" />
     </rule>
     <rule ref="WordPress-Extra"/>
     <rule ref="WordPress-Docs"/>
+    <rule ref="PHPCompatibilityWP"/>
+
+    <!-- tests/Pest.php intentionally groups the WordPress test doubles in one file. -->
+    <rule ref="Generic.Files.OneObjectStructurePerFile">
+        <exclude-pattern>tests/Pest.php</exclude-pattern>
+    </rule>
+
+    <!-- Test doubles mirror the signatures they stand in for, unused params included. -->
+    <rule ref="Generic.CodeAnalysis.UnusedFunctionParameter">
+        <exclude-pattern>tests/*</exclude-pattern>
+    </rule>
+
+    <!-- Pest binds its closures to the test case, which this sniff cannot verify statically. -->
+    <rule ref="PHPCompatibility.FunctionDeclarations.NewClosure.ThisFoundOutsideClass">
+        <exclude-pattern>tests/*</exclude-pattern>
+    </rule>
 </ruleset>

AGENTS.md

@@ -9,9 +9,11 @@
 
 ## Build, Test, and Development Commands
 - Run `composer install` after cloning to pull dev dependencies.
-- `composer test` executes the Pest suite with mocked WordPress APIs.
+- `composer qa` runs the full gate: `phpcs`, `phpstan`, then `pest`.
+- `composer pest` executes the Pest suite with mocked WordPress APIs.
+- `composer phpcs` checks the WordPress coding standards and PHP 7.4 compatibility via `.phpcs.xml.dist`; `composer phpcbf` fixes what can be fixed automatically.
 - `composer analyze` runs PHPStan (level 5) against `MslsMenu.php`; keep it passing before pushing.
-- `composer coverage` enables Xdebug coverage for pull request evidence.
+- `composer pest:coverage` enables Xdebug coverage for pull request evidence.
 - `composer build` triggers `bin/git-release.sh`, refreshing `mslsmenu/` and `mslsmenu.zip` for distribution.
 
 ## Coding Style & Naming Conventions
@@ -22,12 +24,13 @@
 ## Testing Guidelines
 - Place new specs in `tests/YourFeatureTest.php`; keep case names descriptive (`it('renders menu item')`).
 - Stub external WP functions with Brain Monkey setup blocks to keep tests deterministic.
-- Run `composer coverage` for behavioral changes and share the summary when coverage changes noticeably.
+- Run `composer pest:coverage` for behavioral changes and share the summary when coverage changes noticeably.
+- `MslsMenu.php` guards against direct access with `ABSPATH`; `tests/bootstrap.php` defines that constant and then loads the plugin, so the suite must keep using it as its PHPUnit bootstrap.
 
 ## Commit & Pull Request Guidelines
 - Write short imperative subjects (≈50 chars) such as `Clean menu walker output`; batch related edits together.
 - Reference GitHub issues in the body (`Refs #123`) and list the commands you ran.
-- PRs should explain the problem, outline the fix, attach UI evidence when relevant, and confirm `composer test` plus `composer analyze`.
+- PRs should explain the problem, outline the fix, attach UI evidence when relevant, and confirm `composer qa` passes.
 
 ## Release Packaging Tips
 - Bump the plugin header version in `MslsMenu.php` and sync the same value into `readme.txt` before building.

MslsMenu.php

@@ -34,6 +34,10 @@
 
 declare( strict_types=1 );
 
+if ( ! defined( 'ABSPATH' ) ) {
+	exit;
+}
+
 /**
  * MslsMenu Class
  *
@@ -154,7 +158,7 @@ public function add_settings(): void {
 	 *
 	 * @param array $args
 	 */
-	public function theme_location( array $args ) {
+	public function theme_location( array $args ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.Found -- Signature is dictated by add_settings_field().
 		$menu_locations  = get_nav_menu_locations();
 		$theme_locations = $this->options->mslsmenu_theme_location ?? '';
 		$options         = array(

README.md

@@ -15,8 +15,9 @@ MslsMenu extends the Multisite Language Switcher by injecting a language picker
 - Configure Multisite Language Switcher as usual; MslsMenu reuses its site mappings automatically.
 
 ## Develop
-- `composer install` pulls dev tools (Pest, PHPStan, Brain Monkey).
-- `composer test` runs the Pest suite; `composer analyze` performs static analysis.
+- `composer install` pulls dev tools (Pest, PHPStan, PHP_CodeSniffer, Brain Monkey).
+- `composer qa` runs the full gate: coding standards, static analysis, then the Pest suite.
+- `composer pest`, `composer phpcs` and `composer phpstan` run the individual steps; `composer phpcbf` auto-fixes coding-standard violations.
 
 ## Contribute
 - Review `AGENTS.md` for project conventions and release steps.

composer.json

@@ -10,18 +10,27 @@
   },
   "require-dev": {
     "pestphp/pest": "^1.22",
-    "brain/monkey": "2.*",
-    "phpstan/phpstan": "^1.8",
-    "szepeviktor/phpstan-wordpress": "^1.1",
-    "phpstan/extension-installer": "^1.1",
+    "brain/monkey": "^2.7.0",
+    "phpstan/phpstan": "^2.2.0",
+    "phpstan/extension-installer": "^1.4",
+    "szepeviktor/phpstan-wordpress": "^2.0.0",
+    "squizlabs/php_codesniffer": "^3.9",
+    "dealerdirect/phpcodesniffer-composer-installer": "^1.0",
+    "wp-coding-standards/wpcs": "^3.1",
+    "phpcompatibility/phpcompatibility-wp": "^2.1",
     "lloc/composer-i18n-scripts": "^1.0"
   },
-  "autoload-dev": {
-      "files": [ "MslsMenu.php" ]
-  },
   "scripts": {
-    "test": "vendor/bin/pest",
-    "coverage": "php -d xdebug.mode=coverage vendor/bin/pest --coverage",
+    "phpcs": "phpcs",
+    "phpcbf": "phpcbf",
+    "phpstan": "vendor/bin/phpstan analyze --memory-limit=2G",
+    "pest": "vendor/bin/pest",
+    "qa": [
+      "@phpcs",
+      "@phpstan",
+      "@pest"
+    ],
+    "pest:coverage": "php -d xdebug.mode=coverage vendor/bin/pest --coverage",
     "analyze": "vendor/bin/phpstan analyze",
     "git-release": "bin/git-release.sh",
     "build": [
@@ -47,6 +56,7 @@
     "allow-plugins": {
       "composer/installers": true,
       "phpstan/extension-installer": true,
+      "dealerdirect/phpcodesniffer-composer-installer": true,
       "pestphp/pest-plugin": true,
       "lloc/composer-i18n-scripts": true
     }

phpunit.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="./vendor/phpunit/phpunit/phpunit.xsd"
-         bootstrap="vendor/autoload.php"
+         bootstrap="tests/bootstrap.php"
          colors="true"
 >
     <testsuites>

readme.txt

@@ -4,7 +4,7 @@ Contributors: realloc
 Donate link: http://www.greenpeace.org/international/
 Tags: multilingual, multisite, language, switcher, menu
 Requires at least: 5.3
-Tested up to: 6.9
+Tested up to: 7.0
 Requires PHP: 7.4
 Stable tag: 2.5.1
 License: GPLv2 or later

tests/Pest.php

@@ -5,7 +5,6 @@ class Options {
 	public static function instance() {
 		return new self();
 	}
-
 }
 
 class Admin {
@@ -17,10 +16,9 @@ public static function init() {
 
 class Link {
 
-	public static function get_types_description()  {
-		return [];
+	public static function get_types_description() {
+		return array();
 	}
-
 }
 
 class Output {
@@ -30,7 +28,7 @@ public static function init() {
 	}
 
 	public function get( $display, $filter = false, $exists = false ) {
-		return [ 'de', 'en' ];
+		return array( 'de', 'en' );
 	}
 }