Merge pull request #340 from lloc/refactoring-version-2-8

lloc · web-flow · commit 08400bce794f · 2024-06-13T19:18:35.000+02:00
Static and not self
diff --git a/includes/MslsOptionsTaxTerm.php b/includes/MslsOptionsTaxTerm.php
@@ -59,12 +59,12 @@ protected static function get_base_defined( string $tax_query ): string {
 			}
 		}
 
-		return self::BASE_DEFINED;
+		return static::BASE_DEFINED;
 	}
 
 	protected static function get_base_option(): string {
-		$base_option = get_option( self::BASE_OPTION, '' );
+		$base_option = get_option( static::BASE_OPTION, '' );
 
-		return $base_option ?: self::BASE_DEFINED;
+		return $base_option ?: static::BASE_DEFINED;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -59,12 +59,12 @@ protected static function get_base_defined( string $tax_query ): string {`
`59`	`59`	`}`
`60`	`60`	`}`
`61`	`61`
`62`		`- return self::BASE_DEFINED;`
	`62`	`+ return static::BASE_DEFINED;`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`protected static function get_base_option(): string {`
`66`		`- $base_option = get_option( self::BASE_OPTION, '' );`
	`66`	`+ $base_option = get_option( static::BASE_OPTION, '' );`
`67`	`67`
`68`		`- return $base_option ?: self::BASE_DEFINED;`
	`68`	`+ return $base_option ?: static::BASE_DEFINED;`
`69`	`69`	`}`
`70`	`70`	`}`