Strict typing applied everywhere (#408)

lloc · web-flow · commit 65cbf6dc116e · 2025-02-05T13:06:29.000+01:00
* Strict typing applied everywhere

* Webpack config adjusted

* NPM packages checked
diff --git a/includes/Map/HrefLang.php b/includes/Map/HrefLang.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls\Map;
 
diff --git a/includes/MslsAdmin.php b/includes/MslsAdmin.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsAdminBar.php b/includes/MslsAdminBar.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsAdminIcon.php b/includes/MslsAdminIcon.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsAdminIconTaxonomy.php b/includes/MslsAdminIconTaxonomy.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsBlock.php b/includes/MslsBlock.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsCli.php b/includes/MslsCli.php
@@ -1,14 +1,20 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
 class MslsCli {
 
 	public static function init(): void {
-		\WP_CLI::add_command( 'msls', array( __CLASS__, 'msls' ) );
+		\WP_CLI::add_command( 'msls blog', array( __CLASS__, 'blog' ) );
 	}
 
-	public function msls( $args, $assoc_args ): void {
-		\WP_CLI::line( 'Hello, World!' );
+	public function blog( $args, $assoc_args ): void {
+		$locale = $args[0] ?? $assoc_args['locale'] ?? null;
+
+		if ( is_null( $locale ) ) {
+			\WP_CLI::error( 'Please, provide a locale!' );
+			return;
+		}
+		$blog = msls_blog( $locale );
 	}
 }
diff --git a/includes/MslsContentFilter.php b/includes/MslsContentFilter.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsContentTypes.php b/includes/MslsContentTypes.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsCustomColumn.php b/includes/MslsCustomColumn.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsCustomColumnTaxonomy.php b/includes/MslsCustomColumnTaxonomy.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsCustomFilter.php b/includes/MslsCustomFilter.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
@@ -54,7 +54,7 @@ public function add_filter(): void {
 			$id = MslsRequest::get( MslsFields::FIELD_MSLS_FILTER, 0 );
 
             // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
-			echo ( new Select( MslsFields::FIELD_MSLS_FILTER, $options, $id ) )->render();
+			echo ( new Select( MslsFields::FIELD_MSLS_FILTER, $options, strval( $id ) ) )->render();
 		}
 	}
 
diff --git a/includes/MslsFields.php b/includes/MslsFields.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsGetSet.php b/includes/MslsGetSet.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsJson.php b/includes/MslsJson.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsLanguageArray.php b/includes/MslsLanguageArray.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsLink.php b/includes/MslsLink.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsLinkImageOnly.php b/includes/MslsLinkImageOnly.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsLinkTextImage.php b/includes/MslsLinkTextImage.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsLinkTextOnly.php b/includes/MslsLinkTextOnly.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsMain.php b/includes/MslsMain.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsOptions.php b/includes/MslsOptions.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsOptionsQuery.php b/includes/MslsOptionsQuery.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsOptionsQueryAuthor.php b/includes/MslsOptionsQueryAuthor.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsOptionsQueryDay.php b/includes/MslsOptionsQueryDay.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsOptionsQueryMonth.php b/includes/MslsOptionsQueryMonth.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsOptionsQueryPostType.php b/includes/MslsOptionsQueryPostType.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsOptionsQueryYear.php b/includes/MslsOptionsQueryYear.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsOptionsTax.php b/includes/MslsOptionsTax.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsOptionsTaxTerm.php b/includes/MslsOptionsTaxTerm.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsOptionsTaxTermCategory.php b/includes/MslsOptionsTaxTermCategory.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsOutput.php b/includes/MslsOutput.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsPlugin.php b/includes/MslsPlugin.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsPostTagClassic.php b/includes/MslsPostTagClassic.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsPostType.php b/includes/MslsPostType.php
@@ -1,10 +1,4 @@
-<?php
-/**
- * MslsPostType
- *
- * @author Dennis Ploetner <re@lloc.de>
- * @since 0.9.8
- */
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsRegistry.php b/includes/MslsRegistry.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsRegistryInstance.php b/includes/MslsRegistryInstance.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsRequest.php b/includes/MslsRequest.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsShortCode.php b/includes/MslsShortCode.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsSqlCacher.php b/includes/MslsSqlCacher.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsTaxonomy.php b/includes/MslsTaxonomy.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/MslsWidget.php b/includes/MslsWidget.php
@@ -1,10 +1,4 @@
-<?php
-/**
- * MslsWidget
- *
- * @author Dennis Ploetner <re@lloc.de>
- * @since 0.9.8
- */
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls;
 
diff --git a/includes/Query/AbstractQuery.php b/includes/Query/AbstractQuery.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls\Query;
 
diff --git a/includes/Query/AuthorPostsCounterQuery.php b/includes/Query/AuthorPostsCounterQuery.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls\Query;
 
diff --git a/includes/Query/BlogsInNetworkQuery.php b/includes/Query/BlogsInNetworkQuery.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls\Query;
 
diff --git a/includes/Query/CleanupOptionsQuery.php b/includes/Query/CleanupOptionsQuery.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls\Query;
 
diff --git a/includes/Query/DatePostsCounterQuery.php b/includes/Query/DatePostsCounterQuery.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls\Query;
 
diff --git a/includes/Query/MonthPostsCounterQuery.php b/includes/Query/MonthPostsCounterQuery.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls\Query;
 
diff --git a/includes/Query/TranslatedPostIdQuery.php b/includes/Query/TranslatedPostIdQuery.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls\Query;
 
diff --git a/includes/Query/YearPostsCounterQuery.php b/includes/Query/YearPostsCounterQuery.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare( strict_types=1 );
 
 namespace lloc\Msls\Query;
 
diff --git a/js/msls-widget-block/block.json b/js/msls-widget-block/block.json
diff --git a/js/msls-widget-block/render.php b/js/msls-widget-block/render.php
diff --git a/package.json b/package.json
@@ -2,19 +2,19 @@
   "scripts": {
     "uglify": "uglifyjs src/msls.js > js/msls.js",
     "less": "lessc css/msls.less css/msls.css --clean-css=\"--s1 --advanced\"",
-    "build-msls-block": "wp-scripts build src/msls-widget-block/index.js --webpack-src-dir=src/msls-widget-block --output-path=js/msls-widget-block",
+    "build-msls-block": "wp-scripts build src/msls-widget-block/index.js --output-path=js/msls-widget-block",
     "build": "npm run uglify && npm run less && npm run build-msls-block"
   },
   "dependencies": {
-    "less": "^4.2.0",
+    "less": "^4.2.2",
     "less-plugin-clean-css": "^1.6.0",
-    "uglify-js": "^3.19.0"
+    "uglify-js": "^3.19.3"
   },
   "devDependencies": {
-    "@playwright/test": "^1.49.0",
-    "@types/node": "^22.10.0",
-    "@wordpress/e2e-test-utils": "^11.13.0",
-    "@wordpress/scripts": "^30.6.0",
-    "dotenv": "^16.4.0"
+    "@playwright/test": "^1.50.1",
+    "@types/node": "^22.13.1",
+    "@wordpress/e2e-test-utils": "^11.17.0",
+    "@wordpress/scripts": "^30.10.0",
+    "dotenv": "^16.4.7"
   }
 }
diff --git a/tests/phpunit/TestMslsRequest.php b/tests/phpunit/TestMslsRequest.php

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<?php`
	`1`	`+<?php declare( strict_types=1 );`
`2`	`2`
`3`	`3`	`namespace lloc\Msls\Map;`
`4`	`4`