Suppress verified false-positive PHPCS/Plugin Check warnings, remove redundant textdomain load (#670)

* Remove discouraged load_plugin_textdomain() call, add missing docblock tags

WordPress.org already auto-loads this plugin's bundled translations by
matching the text domain to the plugin slug, so the manual
load_plugin_textdomain() call flagged by the WordPress.org Plugin
Check tool is unnecessary. Also add the @var/@PARAM docblock tags on
Plugin.php flagged by PHPCS.

* Suppress verified false-positive PHPCS/Plugin Check warnings

Add justified phpcs:ignore comments for two categories of warnings
verified as false positives or accepted risk during the Plugin Check
review, so CI comes back clean instead of carrying unexplained
warnings:

- WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound
  (call sites): PHPCS cannot statically resolve a self::CONST value,
  but every constant used is already prefixed with "msls_".
- WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in
  (call sites): admin-only or capability-checked, paginated queries
  where the excluded-ID set comes from TranslatedPostIdQuery, not
  attacker-controlled input.

---------

Co-authored-by: Dennis Ploetner <re@lloc.de>

Author: miyanialkesh7

includes/Admin/Admin.php

@@ -253,7 +253,7 @@ public function register(): void {
 		 *
 		 * @since 1.0
 		 */
-		do_action( self::MSLS_REGISTER_ACTION, __CLASS__ );
+		do_action( self::MSLS_REGISTER_ACTION, __CLASS__ ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound -- constant value is already prefixed with "msls_".
 	}
 
 	/**
@@ -357,7 +357,7 @@ protected function add_settings_fields( array $map, string $section ): int {
 		 *
 		 * @since 2.4.4
 		 */
-		do_action( self::MSLS_ACTION_PREFIX . $section, __CLASS__, $section );
+		do_action( self::MSLS_ACTION_PREFIX . $section, __CLASS__, $section ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound -- MSLS_ACTION_PREFIX is already prefixed with "msls_".
 
 		return count( $map );
 	}

includes/Admin/CustomFilter.php

@@ -86,6 +86,7 @@ public function execute_filter( \WP_Query $query ) {
 		$sql_cache = SqlCacher::create( __CLASS__, __METHOD__ );
 
 		// Load post we need to exclude (they already have a translation) from search query.
+		// phpcs:ignore WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in -- admin-only, paginated post-list screen; the excluded-ID set is bounded by TranslatedPostIdQuery, not attacker-controlled.
 		$query->query_vars['post__not_in'] = ( new TranslatedPostIdQuery( $sql_cache ) )( $blog->get_language() );
 
 		return $query;

includes/Admin/Main.php

@@ -148,7 +148,7 @@ protected function save( $object_id, $class_name ): void {
 			 *
 			 * @since 0.9.9
 			 */
-			do_action( self::MSLS_SAVE_ACTION, $object_id, $class_name );
+			do_action( self::MSLS_SAVE_ACTION, $object_id, $class_name ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound -- constant value is already prefixed with "msls_".
 
 			return;
 		}

includes/Admin/PostTag/Classic.php

@@ -40,7 +40,7 @@ public function add_input( string $taxonomy ): void {
 		$this->the_input( null, $title_format, $item_format );
 		echo '</div>';
 
-		do_action( self::MSLS_ADD_INPUT_ACTION, $taxonomy );
+		do_action( self::MSLS_ADD_INPUT_ACTION, $taxonomy ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound -- constant value is already prefixed with "msls_".
 	}
 
 	/**
@@ -72,7 +72,7 @@ public function edit_input( \WP_Term $tag, string $taxonomy ): void {
 
 		$this->the_input( $tag, $title_format, $item_format );
 
-		do_action( self::MSLS_EDIT_INPUT_ACTION, $tag, $taxonomy );
+		do_action( self::MSLS_EDIT_INPUT_ACTION, $tag, $taxonomy ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound -- constant value is already prefixed with "msls_".
 	}
 
 	/**

includes/Admin/PostTag/PostTag.php

@@ -144,7 +144,7 @@ public function add_input( string $taxonomy ): void {
 		$this->the_input( null, $title_format, $item_format );
 		echo '</div>';
 
-		do_action( self::MSLS_ADD_INPUT_ACTION, $taxonomy );
+		do_action( self::MSLS_ADD_INPUT_ACTION, $taxonomy ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound -- constant value is already prefixed with "msls_".
 	}
 
 	/**
@@ -179,7 +179,7 @@ public function edit_input( \WP_Term $tag, string $taxonomy ): void {
 
 		$this->the_input( $tag, $title_format, $item_format );
 
-		do_action( self::MSLS_EDIT_INPUT_ACTION, $tag, $taxonomy );
+		do_action( self::MSLS_EDIT_INPUT_ACTION, $tag, $taxonomy ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound -- constant value is already prefixed with "msls_".
 	}
 
 	/**

includes/Admin/TranslationPicker/Table.php

@@ -179,6 +179,7 @@ public function prepare_items(): void {
 			'post_status'    => array( 'publish', 'draft', 'pending', 'future' ),
 			'posts_per_page' => $per_page,
 			'paged'          => $current_page,
+			// phpcs:ignore WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in -- admin-only, paginated translation-picker list; excluded-ID set comes from TranslatedPostIdQuery, not attacker-controlled.
 			'post__not_in'   => $translated_ids,
 			'orderby'        => 'date',
 			'order'          => 'DESC',

includes/Blog/Blog.php

@@ -143,11 +143,11 @@ protected function get_permalink( OptionsInterface $options ) {
 		switch_to_blog( $this->obj->userblog_id );
 
 		if ( $is_front_page || $options->has_value( $this->get_language() ) ) {
-			$url = apply_filters( self::MSLS_GET_PERMALINK_HOOK, $options->get_permalink( $this->get_language() ), $this );
+			$url = apply_filters( self::MSLS_GET_PERMALINK_HOOK, $options->get_permalink( $this->get_language() ), $this ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound -- constant value is already prefixed with "msls_".
 		} elseif ( $is_posts_page ) {
 			$page_for_posts = (int) get_option( 'page_for_posts' );
 			if ( $page_for_posts > 0 ) {
-				$url = apply_filters( self::MSLS_GET_PERMALINK_HOOK, (string) get_permalink( $page_for_posts ), $this );
+				$url = apply_filters( self::MSLS_GET_PERMALINK_HOOK, (string) get_permalink( $page_for_posts ), $this ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound -- constant value is already prefixed with "msls_".
 			}
 		}
 
@@ -201,7 +201,7 @@ public static function description( Blog $a, Blog $b ) {
 	 */
 	public function get_blavatar(): string {
 		$blavatar_html   = '<div class="blavatar"></div>';
-		$show_site_icons = apply_filters( self::WP_ADMIN_BAR_SHOW_SITE_ICONS_HOOK, true );
+		$show_site_icons = apply_filters( self::WP_ADMIN_BAR_SHOW_SITE_ICONS_HOOK, true ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound -- intentionally reuses WordPress core's own "wp_admin_bar_show_site_icons" hook name, not a plugin-specific hook.
 
 		switch_to_blog( $this->obj->userblog_id );
 

includes/Component/Input/Select.php

@@ -36,7 +36,7 @@ public function __construct( string $key, array $arr, ?string $selected = null )
 	 * @return string
 	 */
 	public function render(): string {
-		$name = apply_filters( self::RENDER_FILTER, 'msls[' . $this->key . ']' );
+		$name = apply_filters( self::RENDER_FILTER, 'msls[' . $this->key . ']' ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound -- constant value is already prefixed with "msls_".
 
 		return sprintf(
 			'<select id="%1$s" name="%2$s">%3$s</select>',

includes/ContentImport/ContentImporter.php

@@ -296,7 +296,7 @@ public function import_content( ImportCoordinates $import_coordinates, array $po
 		 *
 		 * @param ImportCoordinates $import_coordinates
 		 */
-		do_action( self::MSLS_BEFORE_IMPORT_ACTION, $import_coordinates );
+		do_action( self::MSLS_BEFORE_IMPORT_ACTION, $import_coordinates ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound -- constant value is already prefixed with "msls_".
 
 		/**
 		 * Filters the data before the import runs.
@@ -357,7 +357,7 @@ public function import_content( ImportCoordinates $import_coordinates, array $po
 		 *
 		 * @since TBD
 		 */
-		do_action( self::MSLS_AFTER_IMPORT_ACTION, $import_coordinates, $logger, $relations );
+		do_action( self::MSLS_AFTER_IMPORT_ACTION, $import_coordinates, $logger, $relations ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound -- constant value is already prefixed with "msls_".
 
 		/**
 		 * Filters the data after the import ran.

includes/Frontend/Map/HrefLang.php

@@ -66,6 +66,6 @@ public function get( string $language ): string {
 		 *
 		 * @since 0.9.9
 		 */
-		return (string) apply_filters( self::MSLS_HEAD_HREFLANG_HOOK, $language );
+		return (string) apply_filters( self::MSLS_HEAD_HREFLANG_HOOK, $language ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.DynamicHooknameFound -- constant value is already prefixed with "msls_".
 	}
 }