Fix issues in reviews

llvm · Jan 31, 2024 · 5e25553 · 5e25553
1 parent ba4b5aa
commit 5e25553
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/clang/lib/CIR/CodeGen/CIRGenCall.cpp b/clang/lib/CIR/CodeGen/CIRGenCall.cpp
@@ -719,6 +719,9 @@ RValue CIRGenFunction::GetUndefRValue(QualType Ty) {
 mlir::Value CIRGenFunction::buildRuntimeCall(mlir::Location loc,
                                              mlir::cir::FuncOp callee,
                                              ArrayRef<mlir::Value> args) {
+  // TODO(cir): set the calling convention to this runtime call.
+  assert(!UnimplementedFeature::setCallingConv());
+
   auto call = builder.create<mlir::cir::CallOp>(loc, callee, args);
   assert(call->getNumResults() <= 1 &&
          "runtime functions have at most 1 result");

diff --git a/clang/lib/CIR/CodeGen/CIRGenExprCXX.cpp b/clang/lib/CIR/CodeGen/CIRGenExprCXX.cpp
@@ -944,8 +944,7 @@ mlir::Value CIRGenFunction::buildDynamicCast(Address ThisAddr,
   QualType srcRecordTy;
   QualType destRecordTy;
   if (isDynCastToVoid) {
-    srcRecordTy = srcTy->getPointeeType();
-    // No DestRecordTy.
+    llvm_unreachable("NYI");
   } else if (const PointerType *DestPTy = destTy->getAs<PointerType>()) {
     srcRecordTy = srcTy->castAs<PointerType>()->getPointeeType();
     destRecordTy = DestPTy->getPointeeType();

diff --git a/clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp b/clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp
@@ -2188,13 +2188,20 @@ void CIRGenItaniumCXXABI::buildThrow(CIRGenFunction &CGF,
 
 static mlir::cir::FuncOp getBadCastFn(CIRGenFunction &CGF) {
   // Prototype: void __cxa_bad_cast();
+
+  // TODO(cir): set the calling convention of the runtime function.
+  assert(!UnimplementedFeature::setCallingConv());
+
   mlir::cir::FuncType FTy =
       CGF.getBuilder().getFuncType({}, CGF.getBuilder().getVoidTy());
   return CGF.CGM.getOrCreateRuntimeFunction(FTy, "__cxa_bad_cast");
 }
 
 void CIRGenItaniumCXXABI::buildBadCastCall(CIRGenFunction &CGF,
                                            mlir::Location loc) {
+  // TODO(cir): set the calling convention to the runtime function.
+  assert(!UnimplementedFeature::setCallingConv());
+
   CGF.buildRuntimeCall(loc, getBadCastFn(CGF));
   // TODO(cir): mark the current insertion point as unreachable.
 }
@@ -2262,6 +2269,9 @@ static mlir::cir::FuncOp getItaniumDynamicCastFn(CIRGenFunction &CGF) {
 
   // TODO(cir): mark the function as nowind readonly.
 
+  // TODO(cir): set the calling convention of the runtime function.
+  assert(!UnimplementedFeature::setCallingConv());
+
   mlir::cir::FuncType FTy = CGF.getBuilder().getFuncType(
       {VoidPtrTy, RTTIPtrTy, RTTIPtrTy, PtrDiffTy}, VoidPtrTy);
   return CGF.CGM.getOrCreateRuntimeFunction(FTy, "__dynamic_cast");

diff --git a/clang/lib/CIR/CodeGen/UnimplementedFeatureGuarding.h b/clang/lib/CIR/CodeGen/UnimplementedFeatureGuarding.h
@@ -147,6 +147,7 @@ struct UnimplementedFeature {
   static bool isSEHTryScope() { return false; }
   static bool emitScalarRangeCheck() { return false; }
   static bool stmtExprEvaluation() { return false; }
+  static bool setCallingConv() { return false; }
 };
 } // namespace cir