From c4e58420474090601b9419159ad3343ffb530c34 Mon Sep 17 00:00:00 2001 From: Amr Hesham Date: Sat, 1 Feb 2025 00:46:47 +0100 Subject: [PATCH] [CIR] Fix Lowering/ptrstride.cir xfailed after rebasing (#1302) Fixing Lit test after rebasing `CIRToLLVMPtrStrideOpLowering` will not emit casting in this case because the width is equal to *layoutWidth https://github.com/llvm/clangir/blob/d329c96a56b41ad99ddffe7bd037ac4ab7476ce6/clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp#L967-L999 Fixes: #1295 --- clang/test/CIR/Lowering/ptrstride.cir | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/clang/test/CIR/Lowering/ptrstride.cir b/clang/test/CIR/Lowering/ptrstride.cir index 9ab1227fdd0d..8df4d55d1322 100644 --- a/clang/test/CIR/Lowering/ptrstride.cir +++ b/clang/test/CIR/Lowering/ptrstride.cir @@ -1,6 +1,5 @@ // RUN: cir-opt %s -cir-to-llvm -o %t.mlir // RUN: FileCheck %s --input-file=%t.mlir -check-prefix=MLIR -// XFAIL: * !s32i = !cir.int !u64i = !cir.int @@ -15,6 +14,7 @@ module { %4 = cir.load %3 : !cir.ptr, !s32i cir.return } + cir.func @g(%arg0: !cir.ptr, %2 : !s32i) { %3 = cir.ptr_stride(%arg0 : !cir.ptr, %2 : !s32i), !cir.ptr cir.return @@ -38,8 +38,7 @@ module { // MLIR: llvm.return // MLIR-LABEL: @g -// MLIR: %0 = llvm.sext %arg1 : i32 to i64 -// MLIR-NEXT: llvm.getelementptr %arg0[%0] : (!llvm.ptr, i64) -> !llvm.ptr, i32 +// MLIR: llvm.getelementptr %arg0[%arg1] : (!llvm.ptr, i32) -> !llvm.ptr, i32 // MLIR-LABEL: @bool_stride // MLIR: llvm.getelementptr %{{.*}}[%{{.*}}] : (!llvm.ptr, i64) -> !llvm.ptr, i8