Skip to content

Commit 988e062

Browse files
committed
FILECHECKPATH -> FILECHECK and docs for setting this env var
1 parent dca70f7 commit 988e062

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

.github/workflows/examples.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,5 @@ jobs:
2525
2626
- name: Run lit-enabled examples as tests
2727
run: |
28-
export FILECHECKPATH=FileCheck-18 # Ubuntu's llvm-dev appends a version number.
28+
export FILECHECK=FileCheck-18 # Ubuntu's llvm-dev appends a version number.
2929
uv run lit python/examples # Makes sure to substitute FileCheck for $FILECHECKPATH
30-

README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,4 +123,11 @@ pip install .[ingress_torch_cpu] \
123123
Running the tests is as simple as `lit .` in the root of the project.
124124

125125
We assume that the [`FileCheck`](https://llvm.org/docs/CommandGuide/FileCheck.html) and [`lit`](https://llvm.org/docs/CommandGuide/lit.html) executables are available on the `PATH`.
126+
127+
<details>
128+
<summary>
129+
Obtaining `FileCheck` and `lit`.
130+
</summary>
126131
To obtain the [Python package for `lit`](https://pypi.org/project/lit/), simply run `uv sync --group test`.
132+
In case the `FileCheck` executable happens to be available under a different name/location, e.g. as `FileCheck-18` from Ubuntu's `llvm-dev` package, set the `FILECHECK` environment variable when invoking `lit`.
133+
</details>

lit.cfg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@
1212
config.test_exec_root = os.path.dirname(__file__) + "/lit.out"
1313

1414
config.substitutions.append(("%PYTHON", "uv run"))
15-
if filecheck_path := os.environ.get("FILECHECKPATH"):
15+
if filecheck_path := os.environ.get("FILECHECK"):
1616
config.substitutions.append(("FileCheck", filecheck_path))

0 commit comments

Comments
 (0)