Skip to content

Commit ac70e3d

Browse files
[CI] Add resource labels to make terraform plan clean
I should probaly investigate version bumps or something to see if this is fixed later on.
1 parent c3fd748 commit ac70e3d

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

premerge/gke_cluster/main.tf

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,13 @@ resource "google_container_node_pool" "llvm_premerge_linux_service" {
2323

2424
node_config {
2525
machine_type = "e2-highcpu-4"
26+
# Terraform wants to recreate the node pool everytime whe running
27+
# terraform apply unless we explicitly set this.
28+
# TODO(boomanaiden154): Look into why terraform is doing this so we do
29+
# not need this hack.
30+
resource_labels = {
31+
"goog-gke-node-pool-provisioning-model" = "on-demand"
32+
}
2633
}
2734
}
2835

@@ -89,5 +96,12 @@ resource "google_container_node_pool" "llvm_premerge_windows" {
8996
"disable-legacy-endpoints" = "true"
9097
}
9198
disk_size_gb = 200
99+
# Terraform wants to recreate the node pool everytime whe running
100+
# terraform apply unless we explicitly set this.
101+
# TODO(boomanaiden154): Look into why terraform is doing this so we do
102+
# not need this hack.
103+
resource_labels = {
104+
"goog-gke-node-pool-provisioning-model" = "on-demand"
105+
}
92106
}
93107
}

0 commit comments

Comments
 (0)