Correct bug in model and measured ORM #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One bug fix and one improvement when dealing with the calculation of ORM.
Correction of a bug fix in the response_model.SCgetModelRING function where the elements from the original SC.RING PolynomB[0] is set to zero. This is caused by the mutable nature of SC.RING[ord].SetPointA. It can be avoided with a deepcopy. The bug was observed after all my elements with embedded CM lost their corrector strengths after using the response_model.SCgetModelRING function.
Improvement of the loco.measure_closed_orbit_response_matrix function where the CM setpoints are reverted back to their initial value instead of applying the opposite dkick. If the dkick leads the CM strength to exceed its maximum value specified in its CMlimit attribute, computing the measured ORM changes some CM strengths.