asana-task-complete doesn't complete task

[cashpw]

asana-task-complete doesn't complete the task as expected. Instead, it fails for an unknown (to me, yet) reason.

Note that completing with CURL does work:

curl -X PUT https://app.asana.com/api/1.0/tasks/<task_id> \
-H "Authorization: Bearer <auth>" \
-H "Content-Type: application/json" \
-d '{"data":{"completed":true}}'

[cashpw]

asana-task-complete should check if (assoc 'completed data) is literally t, not just if it's truthy. A failure case returns with an (assoc 'completed data) of :false ((completed . :false))

[cashpw]

I have a local fix by overriding asana-task-complete with request. I'm not sure what the root cause is with url-retrieve.

  (defun my/asana-task-complete (task-gid)
    "Complete an Asana task by TASK-GID."
    (request
      (format "https://app.asana.com/api/1.0/tasks/%s" task-gid)
      :sync t
      :type "PUT"
      :data (json-encode `((data (completed . t))))
      :headers
      `(("Content-Type" . "application/json")
        ("Authorization" . ,(concat "Bearer " (asana-get-token))))
      :parser 'json-read
      :success
      (cl-function
       (lambda (&key data &allow-other-keys)
         (lambda (data)
           (let ((task-name (map-elt data 'name)))
             (if (equal t (assoc 'completed data))
                 (message "`%s' completed." task-name)
               (message "Unknown error: couldn't complete `%s': %s"
                        task-name
                        data))))))))
  (advice-add asana-task-complete :override 'my/asana-task-complete)

[cashpw]

@lmartel Do you have any interest in relying on request rather than directly using url-retrieve? I could put a pull request together.