Skip to content

LNX-165: Improve lnx fs cache #217

LNX-165: Improve lnx fs cache

LNX-165: Improve lnx fs cache #217

Triggered via pull request February 16, 2025 18:39
Status Failure
Total duration 1m 16s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

9 errors and 11 warnings
fmt
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
mismatched types: lnx-fs/src/page_cache/mod.rs#L212
error[E0308]: mismatched types --> lnx-fs/src/page_cache/mod.rs:212:39 | 212 | self.write_locks.push(lock_guard); | ---- ^^^^^^^^^^ expected `WriteRequest`, found `MutexGuard<'_, RawMutex, ()>` | | | arguments to this method are incorrect | = note: expected struct `page_cache::WriteRequest` found struct `parking_lot::lock_api::MutexGuard<'_, parking_lot::RawMutex, ()>` note: method defined here --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/smallvec-1.13.2/src/lib.rs:1114:12 | 1114 | pub fn push(&mut self, value: A::Item) { | ^^^^
the size for values of type `str` cannot be known at compilation time: lnx-fs/src/page_cache/gc.rs#L267
error[E0277]: the size for values of type `str` cannot be known at compilation time --> lnx-fs/src/page_cache/gc.rs:267:52 | 267 | } else if let Some(msg) = error.downcast_ref::<str>() { | ------------ ^^^ doesn't have a size known at compile-time | | | required by a bound introduced by this call | = help: the trait `std::marker::Sized` is not implemented for `str` note: required by an implicit `Sized` bound in `<(dyn std::any::Any + 'static)>::downcast_ref` --> /rustc/9cd60bd2ccc41bc898d2ad86728f14035d2df72d/library/core/src/any.rs:225:5
the type `dyn std::ops::FnOnce() + std::marker::Send` may not be safely transferred across an unwind boundary: lnx-fs/src/page_cache/gc.rs#L170
error[E0277]: the type `dyn std::ops::FnOnce() + std::marker::Send` may not be safely transferred across an unwind boundary --> lnx-fs/src/page_cache/gc.rs:170:62 | 170 | if let Err(e) = std::panic::catch_unwind(cb) { | ------------------------ ^^ `dyn std::ops::FnOnce() + std::marker::Send` may not be safely transferred across an unwind boundary | | | required by a bound introduced by this call | = help: the trait `std::panic::UnwindSafe` is not implemented for `dyn std::ops::FnOnce() + std::marker::Send` = note: required for `std::ptr::Unique<dyn std::ops::FnOnce() + std::marker::Send>` to implement `std::panic::UnwindSafe` note: required because it appears within the type `std::boxed::Box<dyn std::ops::FnOnce() + std::marker::Send>` --> /rustc/9cd60bd2ccc41bc898d2ad86728f14035d2df72d/library/alloc/src/boxed.rs:231:12 note: required by a bound in `std::panic::catch_unwind` --> /rustc/9cd60bd2ccc41bc898d2ad86728f14035d2df72d/library/std/src/panic.rs:357:1 help: use parentheses to call this trait object | 170 | if let Err(e) = std::panic::catch_unwind(cb()) { | ++
no field `allocated_pages` on type `&page_cache::block::VirtualFileBlock`: lnx-fs/src/page_cache/block.rs#L193
error[E0609]: no field `allocated_pages` on type `&page_cache::block::VirtualFileBlock` --> lnx-fs/src/page_cache/block.rs:193:15 | 193 | *self.allocated_pages.index(page_idx) | ^^^^^^^^^^^^^^^ unknown field | help: a field with a similar name exists | 193 - *self.allocated_pages.index(page_idx) 193 + *self.pages_allocated.index(page_idx) |
no field `allocated_pages` on type `&mut page_cache::block::VirtualFileBlock`: lnx-fs/src/page_cache/block.rs#L188
error[E0609]: no field `allocated_pages` on type `&mut page_cache::block::VirtualFileBlock` --> lnx-fs/src/page_cache/block.rs:188:24 | 188 | let old = self.allocated_pages.replace(page_idx, false); | ^^^^^^^^^^^^^^^ unknown field | help: a field with a similar name exists | 188 - let old = self.allocated_pages.replace(page_idx, false); 188 + let old = self.pages_allocated.replace(page_idx, false); |
no field `allocated_pages` on type `&mut page_cache::block::VirtualFileBlock`: lnx-fs/src/page_cache/block.rs#L183
error[E0609]: no field `allocated_pages` on type `&mut page_cache::block::VirtualFileBlock` --> lnx-fs/src/page_cache/block.rs:183:24 | 183 | let old = self.allocated_pages.replace(page_idx, true); | ^^^^^^^^^^^^^^^ unknown field | help: a field with a similar name exists | 183 - let old = self.allocated_pages.replace(page_idx, true); 183 + let old = self.pages_allocated.replace(page_idx, true); |
no field `allocated_pages` on type `&page_cache::block::VirtualFileBlock`: lnx-fs/src/page_cache/block.rs#L166
error[E0609]: no field `allocated_pages` on type `&page_cache::block::VirtualFileBlock` --> lnx-fs/src/page_cache/block.rs:166:29 | 166 | if page_idx >= self.allocated_pages.len() { | ^^^^^^^^^^^^^^^ unknown field | help: a field with a similar name exists | 166 - if page_idx >= self.allocated_pages.len() { 166 + if page_idx >= self.pages_allocated.len() { |
clippy
Clippy had exited with the 101 exit code
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
unused variable: `file_id`: lnx-fs/src/page_cache/mod.rs#L99
warning: unused variable: `file_id` --> lnx-fs/src/page_cache/mod.rs:99:9 | 99 | file_id: u64, | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_id`
unused variable: `range`: lnx-fs/src/page_cache/mod.rs#L92
warning: unused variable: `range` --> lnx-fs/src/page_cache/mod.rs:92:50 | 92 | pub fn prepare_read<K: Hash>(&self, file: K, range: Range<usize>) -> io::Result<PreparedRead> { | ^^^^^ help: if this is intentional, prefix it with an underscore: `_range`
unused variable: `file`: lnx-fs/src/page_cache/mod.rs#L92
warning: unused variable: `file` --> lnx-fs/src/page_cache/mod.rs:92:41 | 92 | pub fn prepare_read<K: Hash>(&self, file: K, range: Range<usize>) -> io::Result<PreparedRead> { | ^^^^ help: if this is intentional, prefix it with an underscore: `_file` | = note: `#[warn(unused_variables)]` on by default
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/