Clarify include_tool_for_provider logic

jcorbin · yiwang · commit 11818a64564d · 2026-02-18T21:28:16.000-05:00
diff --git a/crates/core/src/agent/mod.rs b/crates/core/src/agent/mod.rs
@@ -358,7 +358,12 @@ impl Agent {
     }
 
     fn include_tool_for_provider(&self, tool_name: &str) -> bool {
-        !(self.use_native_web_search() && tool_name == "web_search")
+        // Elide the web search tool if the provider support native search
+        if tool_name == "web_search" {
+            return !self.use_native_web_search();
+        }
+
+        true
     }
 
     pub fn tool_names(&self) -> Vec<&str> {

Original file line number	Diff line number	Diff line change
`@@ -358,7 +358,12 @@ impl Agent {`
`358`	`358`	`}`
`359`	`359`
`360`	`360`	`fn include_tool_for_provider(&self, tool_name: &str) -> bool {`
`361`		`- !(self.use_native_web_search() && tool_name == "web_search")`
	`361`	`+ // Elide the web search tool if the provider support native search`
	`362`	`+ if tool_name == "web_search" {`
	`363`	`+ return !self.use_native_web_search();`
	`364`	`+ }`
	`365`	`+`
	`366`	`+ true`
`362`	`367`	`}`
`363`	`368`
`364`	`369`	`pub fn tool_names(&self) -> Vec<&str> {`