Take credentials from the environment

By default, we strip the values so we are overwriting but if the user
specifies the AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY in their
AWS_ENVAR_ALLOWLIST then they can read these from the environment

Author: simonrw

__tests__/index.test.js

@@ -6,6 +6,8 @@ describe("configureEnvironment", () => {
     const allowListStr = "";
     configureEnvironment(env, allowListStr);
     expect(env).toEqual({
+      AWS_ACCESS_KEY_ID: "test",
+      AWS_SECRET_ACCESS_KEY: "test",
       AWS_ENDPOINT_URL: "http://localhost.localstack.cloud:4566",
       AWS_ENDPOINT_URL_S3: "http://s3.localhost.localstack.cloud:4566",
     });
@@ -19,6 +21,8 @@ describe("configureEnvironment", () => {
     const allowListStr = "";
     configureEnvironment(env, allowListStr);
     expect(env).toEqual({
+      AWS_ACCESS_KEY_ID: "test",
+      AWS_SECRET_ACCESS_KEY: "test",
       AWS_ENDPOINT_URL: "http://foo.bar:4567",
       AWS_ENDPOINT_URL_S3: "http://foo.bar:4567",
     });
@@ -39,6 +43,8 @@ describe("configureEnvironment", () => {
     const allowListStr = "";
     configureEnvironment(env, allowListStr);
     expect(env).toEqual({
+      AWS_ACCESS_KEY_ID: "test",
+      AWS_SECRET_ACCESS_KEY: "test",
       AWS_ENDPOINT_URL: "http://localhost.localstack.cloud:4566",
       AWS_ENDPOINT_URL_S3: "http://s3.localhost.localstack.cloud:4566",
     });
@@ -51,9 +57,26 @@ describe("configureEnvironment", () => {
     const allowListStr = "AWS_PROFILE";
     configureEnvironment(env, allowListStr);
     expect(env).toEqual({
+      AWS_ACCESS_KEY_ID: "test",
+      AWS_SECRET_ACCESS_KEY: "test",
       AWS_PROFILE: "my-profile",
       AWS_ENDPOINT_URL: "http://localhost.localstack.cloud:4566",
       AWS_ENDPOINT_URL_S3: "http://s3.localhost.localstack.cloud:4566",
     });
   });
+
+  test("credentials overriding", () => {
+    const env = {
+      AWS_ACCESS_KEY_ID: "something",
+      AWS_SECRET_ACCESS_KEY: "else",
+    };
+    const allowListStr = "AWS_PROFILE,AWS_SECRET_ACCESS_KEY,AWS_ACCESS_KEY_ID";
+    configureEnvironment(env, allowListStr);
+    expect(env).toEqual({
+      AWS_ACCESS_KEY_ID: "something",
+      AWS_SECRET_ACCESS_KEY: "else",
+      AWS_ENDPOINT_URL: "http://localhost.localstack.cloud:4566",
+      AWS_ENDPOINT_URL_S3: "http://s3.localhost.localstack.cloud:4566",
+    });
+  });
 });

src/index.js

@@ -52,6 +52,10 @@ const configureEnvironment = (env, allowListStr) => {
     }
   });
 
+  // set credentials if not set from the environment
+  env.AWS_ACCESS_KEY_ID = env.AWS_ACCESS_KEY_ID || "test";
+  env.AWS_SECRET_ACCESS_KEY = env.AWS_SECRET_ACCESS_KEY || "test";
+
   // Explicitly set AWS_ENDPOINT_URL* to configure network access to LocalStack
   // This _must_ use localhost.localstack.cloud as we require valid subdomains of these paths to
   // resolve. Unfortunately though `curl` seems to support subdomains of localhost, the CDK does not.