Show note if instance is running in the background

Author: gtsiolis

cmd/logout.go

@@ -7,8 +7,10 @@ import (
 
 	"github.com/localstack/lstk/internal/api"
 	"github.com/localstack/lstk/internal/auth"
+	"github.com/localstack/lstk/internal/container"
 	"github.com/localstack/lstk/internal/env"
 	"github.com/localstack/lstk/internal/output"
+	"github.com/localstack/lstk/internal/runtime"
 	"github.com/localstack/lstk/internal/ui"
 	"github.com/spf13/cobra"
 )
@@ -21,7 +23,11 @@ func newLogoutCmd(cfg *env.Env) *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			platformClient := api.NewPlatformClient(cfg.APIEndpoint)
 			if isInteractiveMode(cfg) {
-				return ui.RunLogout(cmd.Context(), platformClient, cfg.AuthToken, cfg.ForceFileKeyring)
+				var rt runtime.Runtime
+				if dockerRuntime, err := runtime.NewDockerRuntime(); err == nil {
+					rt = dockerRuntime
+				}
+				return ui.RunLogout(cmd.Context(), rt, platformClient, cfg.AuthToken, cfg.ForceFileKeyring)
 			}
 
 			sink := output.NewPlainSink(os.Stdout)
@@ -36,6 +42,12 @@ func newLogoutCmd(cfg *env.Env) *cobra.Command {
 				}
 				return fmt.Errorf("failed to logout: %w", err)
 			}
+
+			if rt, err := runtime.NewDockerRuntime(); err == nil {
+				if running, err := container.AnyRunning(cmd.Context(), rt); err == nil && running {
+					output.EmitNote(sink, "LocalStack is still running in the background")
+				}
+			}
 			return nil
 		},
 	}

internal/container/running.go

@@ -0,0 +1,28 @@
+package container
+
+import (
+	"context"
+	"fmt"
+
+	"github.com/localstack/lstk/internal/config"
+	"github.com/localstack/lstk/internal/runtime"
+)
+
+func AnyRunning(ctx context.Context, rt runtime.Runtime) (bool, error) {
+	cfg, err := config.Get()
+	if err != nil {
+		return false, fmt.Errorf("failed to get config: %w", err)
+	}
+
+	for _, c := range cfg.Containers {
+		running, err := rt.IsRunning(ctx, c.Name())
+		if err != nil {
+			return false, fmt.Errorf("checking %s running: %w", c.Name(), err)
+		}
+		if running {
+			return true, nil
+		}
+	}
+
+	return false, nil
+}

internal/container/running_test.go

@@ -0,0 +1,63 @@
+package container
+
+import (
+	"context"
+	"os"
+	"path/filepath"
+	"testing"
+
+	"github.com/localstack/lstk/internal/config"
+	"github.com/localstack/lstk/internal/runtime"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"go.uber.org/mock/gomock"
+)
+
+func TestAnyRunning_ReturnsTrueWhenConfiguredContainerIsRunning(t *testing.T) {
+	initTestConfig(t, `
+[[containers]]
+type = "aws"
+tag = "latest"
+port = "4566"
+`)
+
+	ctrl := gomock.NewController(t)
+	mockRT := runtime.NewMockRuntime(ctrl)
+	mockRT.EXPECT().IsRunning(gomock.Any(), "localstack-aws").Return(true, nil)
+
+	running, err := AnyRunning(context.Background(), mockRT)
+
+	require.NoError(t, err)
+	assert.True(t, running)
+}
+
+func TestAnyRunning_ReturnsFalseWhenConfiguredContainerIsNotRunning(t *testing.T) {
+	initTestConfig(t, `
+[[containers]]
+type = "aws"
+tag = "latest"
+port = "4566"
+`)
+
+	ctrl := gomock.NewController(t)
+	mockRT := runtime.NewMockRuntime(ctrl)
+	mockRT.EXPECT().IsRunning(gomock.Any(), "localstack-aws").Return(false, nil)
+
+	running, err := AnyRunning(context.Background(), mockRT)
+
+	require.NoError(t, err)
+	assert.False(t, running)
+}
+
+func initTestConfig(t *testing.T, content string) {
+	t.Helper()
+
+	dir := t.TempDir()
+	path := filepath.Join(dir, "config.toml")
+	err := os.WriteFile(path, []byte(content), 0o600)
+	require.NoError(t, err)
+	require.NoError(t, config.InitFromPath(path))
+	t.Cleanup(func() {
+		require.NoError(t, config.InitFromPath(path))
+	})
+}

internal/ui/run_logout.go

@@ -8,10 +8,12 @@ import (
 	tea "github.com/charmbracelet/bubbletea"
 	"github.com/localstack/lstk/internal/api"
 	"github.com/localstack/lstk/internal/auth"
+	"github.com/localstack/lstk/internal/container"
 	"github.com/localstack/lstk/internal/output"
+	"github.com/localstack/lstk/internal/runtime"
 )
 
-func RunLogout(parentCtx context.Context, platformClient api.PlatformAPI, authToken string, forceFileKeyring bool) error {
+func RunLogout(parentCtx context.Context, rt runtime.Runtime, platformClient api.PlatformAPI, authToken string, forceFileKeyring bool) error {
 	_, cancel := context.WithCancel(parentCtx)
 	defer cancel()
 
@@ -28,8 +30,14 @@ func RunLogout(parentCtx context.Context, platformClient api.PlatformAPI, authTo
 			return
 		}
 
-		a := auth.New(output.NewTUISink(programSender{p: p}), platformClient, tokenStorage, authToken, "", false)
+		sink := output.NewTUISink(programSender{p: p})
+		a := auth.New(sink, platformClient, tokenStorage, authToken, "", false)
 		err = a.Logout()
+		if err == nil && rt != nil {
+			if running, runningErr := container.AnyRunning(parentCtx, rt); runningErr == nil && running {
+				output.EmitNote(sink, "LocalStack is still running in the background")
+			}
+		}
 
 		runErrCh <- err
 		if err != nil && !errors.Is(err, context.Canceled) && !errors.Is(err, auth.ErrNotLoggedIn) {