address comments

Author: carole-lavillonniere

internal/auth/login.go

@@ -6,6 +6,7 @@ import (
 	"bufio"
 	"context"
 	"fmt"
+	"io"
 	"os"
 	"strings"
 
@@ -48,17 +49,32 @@ func (l *loginProvider) Login(ctx context.Context) (string, error) {
 
 	// Read Y/n response
 	reader := bufio.NewReader(os.Stdin)
-	response, _ := reader.ReadString('\n')
+	response, err := reader.ReadString('\n')
+	if err != nil {
+		if err == io.EOF {
+			// Non-interactive shell, treat as empty (yes)
+			response = ""
+		} else {
+			output.EmitLog(l.sink, fmt.Sprintf("Failed to read input: %v (non-interactive shell?)", err))
+			return "", fmt.Errorf("failed to read input: %w", err)
+		}
+	}
 	response = strings.TrimSpace(strings.ToLower(response))
 
 	// Open browser if yes (default to yes on empty input)
 	if response == "" || response == "y" || response == "yes" {
-		_ = browser.OpenURL(authURL)
+		if err := browser.OpenURL(authURL); err != nil {
+			output.EmitLog(l.sink, fmt.Sprintf("Warning: Failed to open browser: %v", err))
+		}
 	}
 
 	// Wait for ENTER to check status
 	output.EmitLog(l.sink, "Waiting for authentication (Press [ENTER] when complete)")
-	_, _ = reader.ReadString('\n')
+	_, err = reader.ReadString('\n')
+	if err != nil && err != io.EOF {
+		output.EmitLog(l.sink, fmt.Sprintf("Failed to read input: %v", err))
+		return "", fmt.Errorf("failed to read input: %w", err)
+	}
 
 	// Check authentication status once
 	return l.completeAuth(ctx, authReq)

test/integration/login_test.go

@@ -96,16 +96,10 @@ func TestLoginSuccess(t *testing.T) {
 		outputCh <- out
 	}()
 
-	// Wait for instructions
-	time.Sleep(100 * time.Millisecond)
-
 	// Simulate answering "Y" to open browser
 	_, err = stdinPipe.Write([]byte("Y\n"))
 	require.NoError(t, err)
 
-	// Wait a bit for browser to open
-	time.Sleep(100 * time.Millisecond)
-
 	// Simulate pressing ENTER after completing auth in browser
 	_, err = stdinPipe.Write([]byte("\n"))
 	require.NoError(t, err)
@@ -164,16 +158,10 @@ func TestLoginFailure_RequestNotConfirmed(t *testing.T) {
 		outputCh <- out
 	}()
 
-	// Wait for instructions to be printed
-	time.Sleep(100 * time.Millisecond)
-
 	// Simulate answering "Y" to open browser
 	_, err = stdinPipe.Write([]byte("Y\n"))
 	require.NoError(t, err)
 
-	// Wait a bit for browser to open
-	time.Sleep(100 * time.Millisecond)
-
 	// Simulate pressing ENTER after "completing" auth in browser
 	_, err = stdinPipe.Write([]byte("\n"))
 	require.NoError(t, err)