Absolute path and different error

Author: anisaoshafi

internal/snapshot/destination.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"io"
 	"os"
+	"path/filepath"
 	"strings"
 )
 
@@ -16,16 +17,25 @@ type Destination interface {
 // ParseDestination returns a Destination for the user-supplied path, or an error for cloud/bare names.
 func ParseDestination(dest string) (Destination, error) {
 	if dest == "" {
-		return LocalDestination{Path: "ls-state-export"}, nil
-	}
-	if strings.Contains(dest, "://") {
+		dest = "ls-state-export"
+	} else if strings.Contains(dest, "://") {
+		return nil, fmt.Errorf("cloud destinations are not yet supported — use a file path like ./my-snapshot")
+	} else if !strings.HasPrefix(dest, ".") && !strings.HasPrefix(dest, "/") && !strings.HasPrefix(dest, "~") && !strings.Contains(dest, "/") {
+		// bare name with no path separators: reserved for future cloud pod names
 		return nil, fmt.Errorf("cloud destinations are not yet supported — use a file path like ./my-snapshot")
 	}
-	if strings.HasPrefix(dest, ".") || strings.HasPrefix(dest, "/") || strings.HasPrefix(dest, "~") || strings.Contains(dest, "/") {
-		return LocalDestination{Path: dest}, nil
+	if strings.HasPrefix(dest, "~") {
+		home, err := os.UserHomeDir()
+		if err != nil {
+			return nil, fmt.Errorf("resolve home directory: %w", err)
+		}
+		dest = home + dest[1:]
+	}
+	abs, err := filepath.Abs(dest)
+	if err != nil {
+		return nil, fmt.Errorf("resolve path: %w", err)
 	}
-	// bare name with no path separators: reserved for future cloud pod names
-	return nil, fmt.Errorf("cloud destinations are not yet supported — use a file path like ./my-snapshot")
+	return LocalDestination{Path: abs}, nil
 }
 
 // LocalDestination writes snapshot state to a local file.

internal/snapshot/destination_test.go

@@ -1,6 +1,8 @@
 package snapshot_test
 
 import (
+	"os"
+	"path/filepath"
 	"testing"
 
 	"github.com/localstack/lstk/internal/snapshot"
@@ -9,30 +11,35 @@ import (
 )
 
 func TestParseDestination(t *testing.T) {
+	wd, err := os.Getwd()
+	require.NoError(t, err)
+	home, err := os.UserHomeDir()
+	require.NoError(t, err)
+
 	tests := []struct {
-		input   string
-		want    snapshot.Destination
-		wantErr string
+		input    string
+		wantPath string
+		wantErr  string
 	}{
 		{
-			input: "",
-			want:  snapshot.LocalDestination{Path: "ls-state-export"},
+			input:    "",
+			wantPath: filepath.Join(wd, "ls-state-export"),
 		},
 		{
-			input: "./my-state",
-			want:  snapshot.LocalDestination{Path: "./my-state"},
+			input:    "./my-state",
+			wantPath: filepath.Join(wd, "my-state"),
 		},
 		{
-			input: "/tmp/state",
-			want:  snapshot.LocalDestination{Path: "/tmp/state"},
+			input:    "/tmp/state",
+			wantPath: "/tmp/state",
 		},
 		{
-			input: "~/snapshots/s",
-			want:  snapshot.LocalDestination{Path: "~/snapshots/s"},
+			input:    "~/snapshots/s",
+			wantPath: filepath.Join(home, "snapshots/s"),
 		},
 		{
-			input: "subdir/state",
-			want:  snapshot.LocalDestination{Path: "subdir/state"},
+			input:    "subdir/state",
+			wantPath: filepath.Join(wd, "subdir/state"),
 		},
 		{
 			input:   "my-pod",
@@ -58,7 +65,7 @@ func TestParseDestination(t *testing.T) {
 				return
 			}
 			require.NoError(t, err)
-			assert.Equal(t, tc.want, got)
+			assert.Equal(t, snapshot.LocalDestination{Path: tc.wantPath}, got)
 		})
 	}
 }

internal/snapshot/save.go

@@ -45,7 +45,7 @@ func Save(ctx context.Context, rt runtime.Runtime, containers []config.Container
 	w, err := dest.Writer()
 	if err != nil {
 		output.EmitSpinnerStop(sink)
-		return fmt.Errorf("open destination %s: %w", dest, err)
+		return fmt.Errorf("save to %s: %w", dest, err)
 	}
 
 	if _, err := io.Copy(w, body); err != nil {

internal/snapshot/save_test.go

@@ -153,7 +153,7 @@ func TestSave_DestinationDirNotExist(t *testing.T) {
 
 	err := snapshot.Save(context.Background(), healthyRunningMock(t), awsContainers, exporter, dest, sink)
 	require.Error(t, err)
-	assert.Contains(t, err.Error(), "open destination")
+	assert.Contains(t, err.Error(), "save to")
 }
 
 func TestSave_OverwritesExistingFile(t *testing.T) {