Move version info to internal/version package

Author: silv-io

.goreleaser.yaml

@@ -18,7 +18,7 @@ builds:
     flags:
       - -trimpath
     ldflags:
-      - -s -w -X github.com/localstack/lstk/cmd.version={{ .Version }} -X github.com/localstack/lstk/cmd.commit={{ .Commit }} -X github.com/localstack/lstk/cmd.buildDate={{ .Date }}
+      - -s -w -X github.com/localstack/lstk/internal/version.version={{ .Version }} -X github.com/localstack/lstk/internal/version.commit={{ .Commit }} -X github.com/localstack/lstk/internal/version.buildDate={{ .Date }}
 
 archives:
   - id: lstk

cmd/login.go

@@ -5,6 +5,7 @@ import (
 
 	"github.com/localstack/lstk/internal/api"
 	"github.com/localstack/lstk/internal/ui"
+	"github.com/localstack/lstk/internal/version"
 	"github.com/spf13/cobra"
 )
 
@@ -18,7 +19,7 @@ var loginCmd = &cobra.Command{
 			return fmt.Errorf("login requires an interactive terminal")
 		}
 		platformClient := api.NewPlatformClient()
-		return ui.RunLogin(cmd.Context(), version, platformClient)
+		return ui.RunLogin(cmd.Context(), version.Version(), platformClient)
 	},
 }
 

cmd/root.go

@@ -12,13 +12,10 @@ import (
 	"github.com/localstack/lstk/internal/output"
 	"github.com/localstack/lstk/internal/runtime"
 	"github.com/localstack/lstk/internal/ui"
+	"github.com/localstack/lstk/internal/version"
 	"github.com/spf13/cobra"
 )
 
-var version = "dev"
-var commit = "none"
-var buildDate = "unknown"
-
 var rootCmd = &cobra.Command{
 	Use:     "lstk",
 	Short:   "LocalStack CLI",
@@ -39,7 +36,7 @@ var rootCmd = &cobra.Command{
 }
 
 func init() {
-	rootCmd.Version = version
+	rootCmd.Version = version.Version()
 	rootCmd.SetVersionTemplate(versionLine() + "\n")
 	rootCmd.AddCommand(startCmd)
 }
@@ -51,7 +48,7 @@ func Execute(ctx context.Context) error {
 func runStart(ctx context.Context, rt runtime.Runtime) error {
 	platformClient := api.NewPlatformClient()
 	if ui.IsInteractive() {
-		return ui.Run(ctx, rt, version, platformClient)
+		return ui.Run(ctx, rt, version.Version(), platformClient)
 	}
 	return container.Start(ctx, rt, output.NewPlainSink(os.Stdout), platformClient, false)
 }

cmd/version.go

@@ -3,6 +3,7 @@ package cmd
 import (
 	"fmt"
 
+	"github.com/localstack/lstk/internal/version"
 	"github.com/spf13/cobra"
 )
 
@@ -21,5 +22,5 @@ func init() {
 }
 
 func versionLine() string {
-	return fmt.Sprintf("lstk %s (%s, %s)", version, commit, buildDate)
+	return fmt.Sprintf("lstk %s (%s, %s)", version.Version(), version.Commit(), version.BuildDate())
 }

cmd/version_test.go

@@ -1,24 +1,17 @@
 package cmd
 
-import "testing"
+import (
+	"strings"
+	"testing"
+)
 
 func TestVersionLine(t *testing.T) {
-	originalVersion := version
-	originalCommit := commit
-	originalBuildDate := buildDate
-	t.Cleanup(func() {
-		version = originalVersion
-		commit = originalCommit
-		buildDate = originalBuildDate
-	})
-
-	version = "2026.2.0"
-	commit = "abc1234"
-	buildDate = "2026-02-17T15:04:05Z"
-
 	got := versionLine()
-	want := "lstk 2026.2.0 (abc1234, 2026-02-17T15:04:05Z)"
-	if got != want {
-		t.Fatalf("versionLine() = %q, want %q", got, want)
+
+	if !strings.HasPrefix(got, "lstk ") {
+		t.Fatalf("versionLine() = %q, should start with 'lstk '", got)
+	}
+	if !strings.Contains(got, "(") || !strings.Contains(got, ")") {
+		t.Fatalf("versionLine() = %q, should contain parentheses with commit and date", got)
 	}
 }

internal/version/version.go

@@ -0,0 +1,13 @@
+package version
+
+// Set via ldflags at build time. Must be variables, not constants,
+// because the linker can only modify variables at link time.
+var (
+	version   = "dev"
+	commit    = "none"
+	buildDate = "unknown"
+)
+
+func Version() string   { return version }
+func Commit() string    { return commit }
+func BuildDate() string { return buildDate }