Fix linting & paralellize tests

Author: anisaoshafi

cmd/snapshot.go

@@ -38,7 +38,7 @@ The destination must be a file path. Use a path prefix to save locally:
 
 Cloud destinations are not yet supported.`,
 		Args:    cobra.MaximumNArgs(1),
-		PreRunE: initConfig,
+		PreRunE: initConfig(nil),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			var destArg string
 			if len(args) > 0 {

internal/snapshot/client_test.go

@@ -14,6 +14,7 @@ import (
 )
 
 func TestStateClient_ExportState_OK(t *testing.T) {
+	t.Parallel()
 	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		assert.Equal(t, "/_localstack/pods/state", r.URL.Path)
 		assert.Equal(t, http.MethodGet, r.Method)
@@ -33,6 +34,7 @@ func TestStateClient_ExportState_OK(t *testing.T) {
 }
 
 func TestStateClient_ExportState_ServerError(t *testing.T) {
+	t.Parallel()
 	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(http.StatusInternalServerError)
 	}))
@@ -45,6 +47,7 @@ func TestStateClient_ExportState_ServerError(t *testing.T) {
 }
 
 func TestStateClient_ExportState_NotFound(t *testing.T) {
+	t.Parallel()
 	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(http.StatusNotFound)
 	}))
@@ -57,6 +60,7 @@ func TestStateClient_ExportState_NotFound(t *testing.T) {
 }
 
 func TestStateClient_ExportState_ConnectionRefused(t *testing.T) {
+	t.Parallel()
 	// Bind then immediately close to get a port that refuses connections.
 	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {}))
 	addr := srv.URL
@@ -69,6 +73,7 @@ func TestStateClient_ExportState_ConnectionRefused(t *testing.T) {
 }
 
 func TestStateClient_ExportState_ContextCancelled(t *testing.T) {
+	t.Parallel()
 	started := make(chan struct{})
 	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		close(started)
@@ -94,6 +99,7 @@ func TestStateClient_ExportState_ContextCancelled(t *testing.T) {
 }
 
 func TestStateClient_ExportState_LargeBody(t *testing.T) {
+	t.Parallel()
 	const size = 1 << 20 // 1 MB
 	payload := strings.Repeat("X", size)
 

internal/snapshot/destination_test.go

@@ -11,6 +11,7 @@ import (
 )
 
 func TestParseDestination(t *testing.T) {
+	t.Parallel()
 	wd, err := os.Getwd()
 	require.NoError(t, err)
 	home, err := os.UserHomeDir()
@@ -57,6 +58,7 @@ func TestParseDestination(t *testing.T) {
 
 	for _, tc := range tests {
 		t.Run(tc.input, func(t *testing.T) {
+			t.Parallel()
 			got, err := snapshot.ParseDestination(tc.input)
 			if tc.wantErr != "" {
 				require.Error(t, err)

internal/snapshot/save.go

@@ -19,11 +19,11 @@ func Save(ctx context.Context, rt runtime.Runtime, containers []config.Container
 		return output.NewSilentError(fmt.Errorf("runtime not healthy: %w", err))
 	}
 
-	running, err := container.AnyRunning(ctx, rt, containers)
+	runningContainers, err := container.RunningEmulators(ctx, rt, containers)
 	if err != nil {
 		return fmt.Errorf("checking emulator status: %w", err)
 	}
-	if !running {
+	if len(runningContainers) == 0 {
 		sink.Emit(output.ErrorEvent{
 			Title: "LocalStack is not running",
 			Actions: []output.ErrorAction{

internal/snapshot/save_test.go

@@ -52,6 +52,7 @@ func healthyRunningMock(t *testing.T) *runtime.MockRuntime {
 var awsContainers = []config.ContainerConfig{{Type: config.EmulatorAWS}}
 
 func TestSave_Success(t *testing.T) {
+	t.Parallel()
 	dir := t.TempDir()
 	dest := filepath.Join(dir, "snap")
 	exporter := &fakeExporter{body: []byte("ZIP_DATA")}
@@ -89,6 +90,7 @@ func TestSave_Success(t *testing.T) {
 }
 
 func TestSave_EmulatorNotRunning(t *testing.T) {
+	t.Parallel()
 	ctrl := gomock.NewController(t)
 	mockRT := runtime.NewMockRuntime(ctrl)
 	mockRT.EXPECT().IsHealthy(gomock.Any()).Return(nil)
@@ -118,6 +120,7 @@ func TestSave_EmulatorNotRunning(t *testing.T) {
 }
 
 func TestSave_UnhealthyRuntime(t *testing.T) {
+	t.Parallel()
 	ctrl := gomock.NewController(t)
 	mockRT := runtime.NewMockRuntime(ctrl)
 	mockRT.EXPECT().IsHealthy(gomock.Any()).Return(fmt.Errorf("docker unavailable"))
@@ -133,6 +136,7 @@ func TestSave_UnhealthyRuntime(t *testing.T) {
 }
 
 func TestSave_ExporterError(t *testing.T) {
+	t.Parallel()
 	dir := t.TempDir()
 	dest := filepath.Join(dir, "snap")
 	exporter := &fakeExporter{err: fmt.Errorf("connection refused")}
@@ -147,6 +151,7 @@ func TestSave_ExporterError(t *testing.T) {
 }
 
 func TestSave_DestinationDirNotExist(t *testing.T) {
+	t.Parallel()
 	dest := "/no/such/dir/snap"
 	exporter := &fakeExporter{body: []byte("ZIP_DATA")}
 	sink := output.NewPlainSink(io.Discard)
@@ -157,6 +162,7 @@ func TestSave_DestinationDirNotExist(t *testing.T) {
 }
 
 func TestSave_OverwritesExistingFile(t *testing.T) {
+	t.Parallel()
 	dir := t.TempDir()
 	path := filepath.Join(dir, "snap")
 	require.NoError(t, os.WriteFile(path, []byte("OLD"), 0600))
@@ -174,6 +180,7 @@ func TestSave_OverwritesExistingFile(t *testing.T) {
 }
 
 func TestSave_ContextCancelled(t *testing.T) {
+	t.Parallel()
 	ctx, cancel := context.WithCancel(context.Background())
 	cancel()
 

test/integration/snapshot_save_test.go

@@ -140,10 +140,11 @@ func TestSnapshotSaveOverwritesExistingFile(t *testing.T) {
 // TestSnapshotSaveBareNameRejected does not require Docker: destination
 // parsing fails before the runtime is ever touched.
 func TestSnapshotSaveBareNameRejected(t *testing.T) {
+	t.Parallel()
 	ctx := testContext(t)
 	dir := t.TempDir()
 
-	_, stderr, err := runLstk(t, ctx, dir, nil, "--non-interactive", "snapshot", "save", "my-pod")
+	_, stderr, err := runLstk(t, ctx, dir, testEnvWithHome(t.TempDir(), ""), "--non-interactive", "snapshot", "save", "my-pod")
 	requireExitCode(t, 1, err)
 	assert.Contains(t, stderr, "not yet supported")
 	assert.Contains(t, stderr, "./my-snapshot")
@@ -152,10 +153,11 @@ func TestSnapshotSaveBareNameRejected(t *testing.T) {
 // TestSnapshotSaveCloudURIRejected does not require Docker: destination
 // parsing fails before the runtime is ever touched.
 func TestSnapshotSaveCloudURIRejected(t *testing.T) {
+	t.Parallel()
 	ctx := testContext(t)
 	dir := t.TempDir()
 
-	_, stderr, err := runLstk(t, ctx, dir, nil, "--non-interactive", "snapshot", "save", "cloud://my-pod")
+	_, stderr, err := runLstk(t, ctx, dir, testEnvWithHome(t.TempDir(), ""), "--non-interactive", "snapshot", "save", "cloud://my-pod")
 	requireExitCode(t, 1, err)
 	assert.Contains(t, stderr, "not yet supported")
 }