fix: Cleanups

Author: lochmueller

Classes/Domain/Model/Configuration.php

@@ -203,7 +203,7 @@ public function setStartTime(int $startTime): self
      */
     public function getGroups(): ObjectStorage
     {
-        return $this->groups ?? new ObjectStorage();
+        return $this->groups;
     }
 
     /**

Classes/Updates/PluginUpdater.php

@@ -41,7 +41,7 @@ class PluginUpdater extends AbstractUpdate
     public function __construct(
         protected readonly QueryBuilder $contentElementsQueryBuilder,
         protected readonly QueryBuilder $backendGroupsQueryBuilder,
-        protected readonly FlexFormTools $flexFormTools
+        protected readonly FlexFormTools $flexFormTools,
     ) {}
 
     /**
@@ -161,7 +161,7 @@ protected function array2xml(array $input = []): string
         $spaceInd = 4;
         $output = GeneralUtility::array2xml($input, '', 0, 'T3FlexForms', $spaceInd, $options);
 
-        return '<?xml version="1.0" encoding="utf-8" standalone="yes" ?>' . LF . $output;
+        return '<?xml version="1.0" encoding="utf-8" standalone="yes" ?>' . "\n" . $output;
     }
 
     protected function updateContentElement(int $uid, string $newListType, string $flexform): void

Classes/ViewHelpers/Be/RecordRowViewHelper.php

@@ -6,7 +6,6 @@
 
 use HDNET\Calendarize\ViewHelpers\AbstractViewHelper;
 use TYPO3\CMS\Backend\Utility\BackendUtility;
-use TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface;
 
 /**
  * Gets the record by uid from the table as an array.

Classes/ViewHelpers/DateTime/FormatUtcDateViewHelper.php

@@ -5,7 +5,6 @@
 namespace HDNET\Calendarize\ViewHelpers\DateTime;
 
 use HDNET\Calendarize\ViewHelpers\Format\DateViewHelper;
-use TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface;
 use TYPO3Fluid\Fluid\Core\ViewHelper\Exception;
 
 /**

Classes/ViewHelpers/Format/DateViewHelper.php

@@ -7,7 +7,6 @@
 use TYPO3\CMS\Core\Context\Context;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Core\Utility\MathUtility;
-use TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface;
 use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper;
 use TYPO3Fluid\Fluid\Core\ViewHelper\Exception;
 
@@ -69,6 +68,7 @@ public function render()
             $format = $GLOBALS['TYPO3_CONF_VARS']['SYS']['ddmmyy'] ?: 'Y-m-d';
         }
 
+        // @todo check
         $date = $renderChildrenClosure();
         if (null === $date) {
             return '';

Classes/ViewHelpers/Format/LineFoldingViewHelper.php

@@ -5,7 +5,6 @@
 namespace HDNET\Calendarize\ViewHelpers\Format;
 
 use HDNET\Calendarize\ViewHelpers\AbstractViewHelper;
-use TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface;
 
 /**
  * Class LineFoldingViewHelper.

Classes/ViewHelpers/Format/RemoveBlankLinesViewHelper.php

@@ -5,7 +5,6 @@
 namespace HDNET\Calendarize\ViewHelpers\Format;
 
 use HDNET\Calendarize\ViewHelpers\AbstractViewHelper;
-use TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface;
 
 /**
  * Class RemoveBlankLinesViewHelper.

Classes/ViewHelpers/InArrayViewHelper.php

@@ -4,8 +4,6 @@
 
 namespace HDNET\Calendarize\ViewHelpers;
 
-use TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface;
-
 /**
  * Checks if an element (needle) is in an array (haystack).
  */

Classes/ViewHelpers/Link/AbstractLinkViewHelper.php

@@ -7,9 +7,7 @@
 use Psr\Http\Message\ServerRequestInterface;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Core\Utility\MathUtility;
-use TYPO3\CMS\Extbase\Mvc\RequestInterface;
 use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
-use TYPO3\CMS\Fluid\Core\Rendering\RenderingContext;
 use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractTagBasedViewHelper;
 
 /**
@@ -39,7 +37,7 @@ public function initializeArguments(): void
         $this->registerArgument(
             'rel',
             'string',
-            'Specifies the relationship between the current document and the linked document'
+            'Specifies the relationship between the current document and the linked document',
         );
     }
 

Classes/Widgets/DataProvider/NextEventsDataProvider.php

@@ -17,7 +17,7 @@ class NextEventsDataProvider implements ListDataProviderInterface
 {
     public function __construct(
         protected IndexRepository $indexRepository,
-        protected ViewFactoryInterface $viewFactory
+        protected ViewFactoryInterface $viewFactory,
     ) {}
 
     public function getItems(): array
@@ -35,9 +35,9 @@ public function getItems(): array
                     [],
                     [
                         'EXT:calendarize/Resources/Private/Partials/',
-                        'EXT:calendarize_premium/Resources/Private/Partials/'
+                        'EXT:calendarize_premium/Resources/Private/Partials/',
                     ],
-                    []
+                    [],
                 );
 
                 /** @var ViewInterface $view */