Add a working "fill" mode to Image Resize Effect

locomotivemtl · Feb 23, 2018 · dce39d8 · dce39d8
1 parent 6b7a851
commit dce39d8
Showing 1 changed file with 20 additions and 6 deletions.
diff --git a/src/Charcoal/Image/Effect/AbstractResizeEffect.php b/src/Charcoal/Image/Effect/AbstractResizeEffect.php
@@ -470,12 +470,26 @@ public function process(array $data = null)
                 );
 
             case 'fill':
-                $imgClass = get_class($this->image());
-                $canvas = new $imgClass;
-                $canvas->create($this->width(), $this->width(), $this->backgroundColor());
-                throw new Exception(
-                    'Crop resize mode is not (yet) supported'
-                );
+                $newWidth = $this->width();
+                $newHeight = $this->height();
+
+                $oldRatio = ($imageWidth / $imageHeight);
+                $newRatio = ($newWidth / $newHeight);
+
+                if ($newRatio > $oldRatio) {
+                    $newHeight = ($imageHeight * $this->width() / $imageWidth);
+                } else {
+                    $newWidth = ($imageWidth * $this->height() / $imageHeight);
+                }
+
+                $this->doResize($newWidth, $newHeight);
+
+                // $imgClass = get_class($this->image());
+                // $canvas = new $imgClass;
+                // $canvas->create($this->width(), $this->width(), $this->backgroundColor());
+                // throw new Exception(
+                //     'Crop resize mode is not (yet) supported'
+                // );
         }
 
         return $this;