change inheritance HtmlProperty from StringProperty to TextProperty t…

…o allow SQL type LONGTEXT. Set HtmlProperty type LONGTEXT by default.
locomotivemtl · Mar 17, 2020 · 2f148aa · 2f148aa
1 parent e762f86
commit 2f148aa
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 13 deletions.
diff --git a/src/Charcoal/Property/HtmlProperty.php b/src/Charcoal/Property/HtmlProperty.php
@@ -3,15 +3,22 @@
 namespace Charcoal\Property;
 
 // From 'charcoal-property'
-use Charcoal\Property\StringProperty;
+use Charcoal\Property\TextProperty;
 
 /**
  * HTML Property.
  *
  * The html property is a specialized string property.
  */
-class HtmlProperty extends StringProperty
+class HtmlProperty extends TextProperty
 {
+    const DEFAULT_LONG = true;
+
+    /**
+     * @var boolean
+     */
+    protected $long = self::DEFAULT_LONG;
+
     /**
      * The available filesystems (used in TinyMCE's elFinder media manager).
      *
@@ -67,14 +74,4 @@ public function getAllowHtml()
     {
         return true;
     }
-
-    /**
-     * Get the SQL type (Storage format).
-     *
-     * @return string The SQL type
-     */
-    public function sqlType()
-    {
-        return 'TEXT';
-    }
 }
diff --git a/src/Charcoal/Property/TextProperty.php b/src/Charcoal/Property/TextProperty.php
@@ -15,7 +15,7 @@ class TextProperty extends StringProperty
     /**
      * @var boolean
      */
-    private $long = self::DEFAULT_LONG;
+    protected $long = self::DEFAULT_LONG;
 
     /**
      * @return string

diff --git a/tests/Charcoal/Property/HtmlPropertyTest.php b/tests/Charcoal/Property/HtmlPropertyTest.php
@@ -50,6 +50,7 @@ public function testDefaults()
         $this->assertTrue($this->obj['allowNull']);
         $this->assertTrue($this->obj['allowHtml']);
         $this->assertTrue($this->obj['active']);
+        $this->assertTrue($this->obj['long']);
     }
 
     /**
@@ -66,7 +67,11 @@ public function testDefaultMaxLength()
      */
     public function testSqlType()
     {
+        $this->obj->setLong(false);
         $this->assertEquals('TEXT', $this->obj->sqlType());
+
+        $this->obj->setLong(true);
+        $this->assertEquals('LONGTEXT', $this->obj->sqlType());
     }
 
     public function testFilesystem()