Merge pull request #20 from locustio/improve-spans

Improve trace spans

Author: cyberw

src/aiolocust/users/http.py

@@ -107,7 +107,7 @@ async def __aenter__(self) -> LocustResponse:
             await super().__aenter__()
         except (ClientConnectorError, ClientResponseError, TimeoutError) as e:
             if request_info := getattr(e, "request_info", None):
-                url = request_info.url
+                url = str(request_info.url)
             else:
                 url = self.str_or_url
             self.span.record_exception(e)
@@ -151,6 +151,7 @@ async def __aexit__(
             else:
                 # wrap plain strings in Exceptions. Callstack may be confusing, but it is better than nothing
                 self.span.record_exception(Exception(err))
+        self.span.set_attribute("http.status", str(self._resp.status))
         context.detach(self._token)
         self.span.end(self.end_time)
 

tests/test_zzaiolocust.py

@@ -108,6 +108,8 @@ async def run(user):
     logger.info("info level log message")
     async with user.client.get("http://localhost:8081/") as resp:
         pass
+    async with user.client.get("http://localhost:8081/500") as resp:
+        pass
 """)
         proc = await asyncio.create_subprocess_exec(
             "aiolocust",
@@ -135,9 +137,13 @@ async def run(user):
             err = stderr.decode(errors="replace")
             print(err)
             output = stdout.decode(errors="replace")
+            print(output)
             assert "warning level log message" in err
             assert "info level log message" not in err
             assert "exception" not in err.lower()
+            # test some span stuff while we are at it
+            assert '"http.status": "200"' in output
+            assert '"http.status": "500"' in output
             assert await proc.wait() == 0