Merge pull request #3085 from locustio/dont-crash-if-parameters-are-passed-to-failure-when-someone-forgot-catch_response-True

cyberw · web-flow · commit b3bae7d0d279 · 2025-03-28T17:37:57.000+01:00
FastHttpUser: Dont crash if parameters are passed to failure() when someone forgot catch_response=True
diff --git a/locust/contrib/fasthttp.py b/locust/contrib/fasthttp.py
@@ -568,7 +568,7 @@ def success(self):
             "If you want to change the state of the request, you must pass catch_response=True. See http://docs.locust.io/en/stable/writing-a-locustfile.html#validating-responses"
         )
 
-    def failure(self):
+    def failure(self, *_args, **_kwargs):
         raise LocustError(
             "If you want to change the state of the request, you must pass catch_response=True. See http://docs.locust.io/en/stable/writing-a-locustfile.html#validating-responses"
         )

Original file line number	Diff line number	Diff line change
`@@ -568,7 +568,7 @@ def success(self):`
`568`	`568`	`"If you want to change the state of the request, you must pass catch_response=True. See http://docs.locust.io/en/stable/writing-a-locustfile.html#validating-responses"`
`569`	`569`	`)`
`570`	`570`
`571`		`- def failure(self):`
	`571`	`+ def failure(self, _args, *_kwargs):`
`572`	`572`	`raise LocustError(`
`573`	`573`	`"If you want to change the state of the request, you must pass catch_response=True. See http://docs.locust.io/en/stable/writing-a-locustfile.html#validating-responses"`
`574`	`574`	`)`