Skip to content

Commit 08c3bf3

Browse files
committed
Update CORE_MAINTAINER.md
1 parent c31cca5 commit 08c3bf3

File tree

1 file changed

+15
-8
lines changed

1 file changed

+15
-8
lines changed

CORE_MAINTAINER.md

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,22 @@ Note that for any task, it's important to first get ample context. Search past i
1919
2. Use `gh` to check on pending PRs. First run `gh auth status` to understand what our GitHub identity is. Make sure all PRs have reviews by other people than our identity (fixable only when PRs are submitted by others), that PRs pass (fixable only if they were submitted by US), fix what can be fixed, then re-check next iteration. If all is green, merge. LLMs should refrain from commenting on PRs, but deep reviews on PRs by others are allowed.
2020
3. Triage issues. Confirm repro, decide scope, and say no when needed to protect project goals (see `## Vision`, `README.md`, `CHANGELOG.md`, and `website/source/about.md`). LLMs should refrain from commenting on Issues.
2121
4. To continuously modernize the project, revise the Backlog/Roadmap in `CHANGELOG.md`. Don't forget about the website, which lives in this repo and is deployed via GHA. Check off items and/or move them into releases as appropriate.
22-
5. Decide an issue to work on. It could come from the Backlog/Roadmap in `CHANGELOG.md`, a verified GitHub issue, a PR failure, unfinished business, or a security concern. Do what is most important and impactful first. First search what is already available, and what we can already re-use, even if it takes a little refactoring. Define what a successful outcome looks like and how you'll validate it (tests, browser checks, screenshots for design changes, or a working migration). This is imperative: no changes without validation. Anything that can't be validated should not be PR'ed or merged.
22+
5. Decide an issue to work on. It could come from
23+
- the Backlog/Roadmap in `CHANGELOG.md`, a verified GitHub issue,
24+
- a PR failure,
25+
- upgrading outdated dependencies, checking release notes, taking care of the potential migration, leveraging new capabilities
26+
- unfinished business
27+
- a security concern
28+
29+
Do what is most important and impactful first. First search what is already available, and what we can already re-use, even if it takes a little refactoring. Define what a successful outcome looks like and how you'll validate it (tests, browser checks, screenshots for design changes, or a working migration). This is imperative: no changes without validation. Anything that can't be validated should not be PR'ed or merged.
2330
6. **NEVER commit directly to `main`.** Always create a feature branch and open a PR:
24-
```bash
25-
git checkout -b fix/descriptive-name # or feat/, chore/, docs/
26-
# ... make changes ...
27-
git push -u origin HEAD
28-
gh pr create
29-
```
30-
Exceptions: `CORE_MAINTAINER.md`, `CHANGELOG.md`, and `docs/prompts/LOG.md` can be pushed directly to main.
31+
```bash
32+
git checkout -b fix/descriptive-name # or feat/, chore/, docs/
33+
# ... make changes ...
34+
git push -u origin HEAD
35+
gh pr create
36+
```
37+
Exceptions: `CORE_MAINTAINER.md`, `CHANGELOG.md`, and `docs/prompts/LOG.md` can be pushed directly to main.
3138
7. Log in the/a Iteration what the plan is
3239
8. Start implementing
3340
9. After the change:

0 commit comments

Comments
 (0)