fix regression in classes with multiple init only fields/properties

Author: Maxim Becker

FastCloner.Tests/SpecialCaseTests.cs

@@ -3235,4 +3235,33 @@ private class ClassWithWritableValueTypeField
         private decimal readOnlyField = 1m;
         public decimal ReadOnlyValue => readOnlyField;
     }
+    
+    [Test]
+    public void SelfReferenced_WithMultipleReadOnlyProperties_Test()
+    {
+        SelfReferencedWithMultipleReadOnlyProperties original = new SelfReferencedWithMultipleReadOnlyProperties
+        {
+            WithMultipleReadOnlyProperties = new ClassWithMultipleReadOnlyProperties()
+        };
+    
+        SelfReferencedWithMultipleReadOnlyProperties clone = original.DeepClone();
+    	
+        Assert.That(clone, Is.Not.SameAs(original));
+        Assert.That(clone.WithMultipleReadOnlyProperties, Is.Not.SameAs(original.WithMultipleReadOnlyProperties));
+        Assert.That(clone.WithMultipleReadOnlyProperties.Name, Is.EqualTo(original.WithMultipleReadOnlyProperties.Name));
+        Assert.That(clone.WithMultipleReadOnlyProperties.Id, Is.EqualTo(original.WithMultipleReadOnlyProperties.Id));
+    }
+    
+    private class SelfReferencedWithMultipleReadOnlyProperties
+    {
+        public SelfReferencedWithMultipleReadOnlyProperties? Predecessor { get; set; }
+    
+        public ClassWithMultipleReadOnlyProperties WithMultipleReadOnlyProperties { get; set; }
+    }
+
+    private class ClassWithMultipleReadOnlyProperties
+    {
+        public int Id { get; } = 1;
+        public string Name { get; } = "Test";
+    }
 }

FastCloner/Code/FastClonerCache.cs

@@ -17,14 +17,14 @@ internal static bool IsTypeIgnored(Type type)
     private static readonly ClrCache<object> deepClassToCache = new ClrCache<object>();
     private static readonly ClrCache<object> shallowClassToCache = new ClrCache<object>();
     private static readonly ConcurrentLazyCache<object> typeConvertCache = new ConcurrentLazyCache<object>();
-    private static readonly ClrCache<object?> fieldCache = new ClrCache<object?>();
+    private static readonly GenericClrCache<Tuple<Type, string>, object?> fieldCache = new GenericClrCache<Tuple<Type, string>, object?>();
     private static readonly ClrCache<Dictionary<string, Type>> ignoredEventInfoCache = new ClrCache<Dictionary<string, Type>>();
     private static readonly ClrCache<List<MemberInfo>> allMembersCache = new ClrCache<List<MemberInfo>>();
     private static readonly GenericClrCache<MemberInfo, bool> memberIgnoreStatusCache = new GenericClrCache<MemberInfo, bool>();
     private static readonly ClrCache<bool> typeContainsIgnoredMembersCache = new ClrCache<bool>();
     private static readonly ClrCache<object> specialTypesCache = new ClrCache<object>();
 
-    public static object? GetOrAddField(Type type, Func<Type, object?> valueFactory) => fieldCache.GetOrAdd(type, valueFactory);
+    public static object? GetOrAddField(Type type, string name, Func<Type, object?> valueFactory) => fieldCache.GetOrAdd(new Tuple<Type, string>(type, name), k => valueFactory(k.Item1));
     public static object? GetOrAddClass(Type type, Func<Type, object?> valueFactory) => classCache.GetOrAdd(type, valueFactory);
     public static object? GetOrAddStructAsObject(Type type, Func<Type, object?> valueFactory) => structCache.GetOrAdd(type, valueFactory);
     public static object GetOrAddDeepClassTo(Type type, Func<Type, object> valueFactory) => deepClassToCache.GetOrAdd(type, valueFactory);

FastCloner/Code/FieldAccessorGenerator.cs

@@ -7,7 +7,7 @@ internal static class FieldAccessorGenerator
 {
     internal static Action<object, object> GetFieldSetter(FieldInfo field)
     {
-        return (Action<object, object>)FastClonerCache.GetOrAddField(field.DeclaringType, _ => CreateFieldSetter(field));
+        return (Action<object, object>)FastClonerCache.GetOrAddField(field.DeclaringType, field.Name, _ => CreateFieldSetter(field));
     }
 
     private static Action<object, object> CreateFieldSetter(FieldInfo field)