fix cloning of AssemblyName

Author: lofcz

FastCloner.Tests/SpecialCaseTests.cs

@@ -3023,4 +3023,30 @@ public void Drawing_Brush_DeepClone_Test()
         original.Color = Color.Blue;
         Assert.That(clone.Color.B, Is.EqualTo(0));
     }
+
+    [Test]
+    public void AssemblyName_DeepClone_Test()
+    {
+        // Arrange
+        var original = new AssemblyName
+        {
+            Name = "MyTestAssembly",
+            Version = new Version(1, 2, 3, 4)
+        };
+        var originalVersion = new Version(1, 2, 3, 4);
+
+        // Act
+        var clone = original.DeepClone();
+        original.Version = new Version(5, 6, 7, 8); // Modify the original
+
+        // Assert
+        Assert.Multiple(() =>
+        {
+            Assert.That(clone, Is.Not.Null);
+            Assert.That(clone, Is.Not.SameAs(original));
+            Assert.That(clone.Name, Is.EqualTo("MyTestAssembly"));
+            Assert.That(clone.Version, Is.EqualTo(originalVersion));
+            Assert.That(clone.Version, Is.Not.EqualTo(original.Version));
+        });
+    }
 }

FastCloner/Code/FastClonerExprGenerator.cs

@@ -6,6 +6,7 @@
 using System.Collections.ObjectModel;
 using System.Dynamic;
 using System.Linq.Expressions;
+using System.Net;
 using System.Reflection;
 
 namespace FastCloner.Code;
@@ -132,11 +133,11 @@ public ConstructorInfoEx(ConstructorInfo constructor)
         // take parameterless constructor
         ConstructorInfo? ctor = type.GetConstructor(Type.EmptyTypes);
         return ctor != null ? new ConstructorInfoEx(ctor) : null;
-
+        
         // using any other constructor that can be called without arguments increases chances we trigger side effects
         // we fall back to memberwise cloning instead
-        ctor = type.GetConstructors().FirstOrDefault(c => c.GetParameters().All(p => p.HasDefaultValue));
-        return ctor != null ? new ConstructorInfoEx(ctor) : null;
+        // ctor = type.GetConstructors().FirstOrDefault(c => c.GetParameters().All(p => p.HasDefaultValue));
+        // return ctor != null ? new ConstructorInfoEx(ctor) : null;
     }
 
     private static NewExpression CreateNewExpressionWithCtor(ConstructorInfoEx ctorInfoEx)
@@ -394,7 +395,7 @@ private static object GenerateMemberwiseCloner(Type type, ExpressionPosition pos
         "System.Data.Entity.DynamicProxies.",
         "NHibernate.Proxy."
     ]);
-
+    
     private static readonly Dictionary<string, Func<Type, object?>> specialNamespaces = new Dictionary<string, Func<Type, object?>> 
     {
         // these can be trusted to have their Clone() implemented properly

FastCloner/Code/FastClonerSafeTypes.cs

@@ -104,7 +104,16 @@ private static class TypePrefixes
     }
 
     private static readonly Assembly propertyInfoAssembly = typeof(PropertyInfo).Assembly;
-    private static bool IsReflectionType(Type type) => type.FullName?.StartsWith(TypePrefixes.SystemReflection) is true && Equals(type.GetTypeInfo().Assembly, typeof(PropertyInfo).GetTypeInfo().Assembly);
+    
+    private static bool IsReflectionType(Type type)
+    {
+        if (type == typeof(AssemblyName))
+        {
+            return false;
+        }
+    
+        return type.FullName?.StartsWith(TypePrefixes.SystemReflection) is true && Equals(type.GetTypeInfo().Assembly, typeof(PropertyInfo).GetTypeInfo().Assembly);
+    }
 
     private static IEnumerable<FieldInfo> GetAllTypeFields(Type type)
     {