Skip to content

Commit 1c55321

Browse files
committed
fix: document bi-directionality of secret stores
1 parent d199732 commit 1c55321

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

Diff for: chart/values.schema.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1889,7 +1889,7 @@
18891889
},
18901890
"stores": {
18911891
"$ref": "#/$defs/EnableSwitch",
1892-
"description": "Stores defines if secret stores should get synced from the virtual cluster to the host cluster."
1892+
"description": "Stores defines if secret stores should get synced from the virtual cluster to the host cluster and then bi-directionally."
18931893
},
18941894
"clusterStores": {
18951895
"$ref": "#/$defs/ClusterStoresSyncConfig",
@@ -2066,7 +2066,7 @@
20662066
},
20672067
"externalSecrets": {
20682068
"$ref": "#/$defs/ExternalSecrets",
2069-
"description": "ExternalSecrets reuses a host external secret operator and makes certain CRDs from it available inside the vCluster.\n- ExternalSecrets will be synced from the virtual cluster to the host cluster.\n- SecretStores will be synced bi-directionally.\n- ClusterSecretStores will be synced from the host cluster to the virtual cluster."
2069+
"description": "ExternalSecrets reuses a host external secret operator and makes certain CRDs from it available inside the vCluster.\n- ExternalSecrets will be synced from the virtual cluster to the host cluster.\n- SecretStores will be synced from the virtual cluster to the host cluster and then bi-directionally.\n- ClusterSecretStores will be synced from the host cluster to the virtual cluster."
20702070
},
20712071
"certManager": {
20722072
"$ref": "#/$defs/CertManager",

Diff for: chart/values.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -719,7 +719,7 @@ integrations:
719719

720720
# ExternalSecrets reuses a host external secret operator and makes certain CRDs from it available inside the vCluster.
721721
# - ExternalSecrets will be synced from the virtual cluster to the host cluster.
722-
# - SecretStores will be synced bi-directionally.
722+
# - SecretStores will be synced from the virtual cluster to the host cluster and then bi-directionally.
723723
# - ClusterSecretStores will be synced from the host cluster to the virtual cluster.
724724
externalSecrets:
725725
# Enabled defines whether the external secret integration is enabled or not
@@ -732,7 +732,7 @@ integrations:
732732
# ExternalSecrets defines if external secrets should get synced from the virtual cluster to the host cluster.
733733
externalSecrets:
734734
enabled: true
735-
# Stores defines if secret stores should get synced from the virtual cluster to the host cluster.
735+
# Stores defines if secret stores should get synced from the virtual cluster to the host cluster and then bi-directionally.
736736
stores:
737737
enabled: false
738738
# ClusterStores defines if cluster secrets stores should get synced from the host cluster to the virtual cluster.

Diff for: config/config.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ type Integrations struct {
9292

9393
// ExternalSecrets reuses a host external secret operator and makes certain CRDs from it available inside the vCluster.
9494
// - ExternalSecrets will be synced from the virtual cluster to the host cluster.
95-
// - SecretStores will be synced bi-directionally.
95+
// - SecretStores will be synced from the virtual cluster to the host cluster and then bi-directionally.
9696
// - ClusterSecretStores will be synced from the host cluster to the virtual cluster.
9797
ExternalSecrets ExternalSecrets `json:"externalSecrets,omitempty"`
9898

@@ -167,7 +167,7 @@ type ExternalSecrets struct {
167167
type ExternalSecretsSync struct {
168168
// ExternalSecrets defines if external secrets should get synced from the virtual cluster to the host cluster.
169169
ExternalSecrets EnableSwitch `json:"externalSecrets,omitempty"`
170-
// Stores defines if secret stores should get synced from the virtual cluster to the host cluster.
170+
// Stores defines if secret stores should get synced from the virtual cluster to the host cluster and then bi-directionally.
171171
Stores EnableSwitch `json:"stores,omitempty"`
172172
// ClusterStores defines if cluster secrets stores should get synced from the host cluster to the virtual cluster.
173173
ClusterStores ClusterStoresSyncConfig `json:"clusterStores,omitempty"`

0 commit comments

Comments
 (0)