bugfix: disallow users from creating a vCluster in the platform namespace

Author: neogopher

chart/templates/service.yaml

@@ -1,4 +1,7 @@
-{{- if .Values.controlPlane.service.enabled }}
+{{- $platform_svc_exists := lookup "v1" "Service" .Release.Namespace "loft" }}
+{{- if $platform_svc_exists }}
+{{- fail (printf "a vCluster platform installation exists in the namespace '%s'. Aborting install" .Release.Namespace) }}
+{{- else if .Values.controlPlane.service.enabled }}
 apiVersion: v1
 kind: Service
 metadata:

pkg/cli/create_helm.go

@@ -33,6 +33,7 @@ import (
 	"github.com/loft-sh/vcluster/pkg/embed"
 	"github.com/loft-sh/vcluster/pkg/helm"
 	"github.com/loft-sh/vcluster/pkg/platform"
+	platformclihelper "github.com/loft-sh/vcluster/pkg/platform/clihelper"
 	"github.com/loft-sh/vcluster/pkg/snapshot"
 	"github.com/loft-sh/vcluster/pkg/snapshot/pod"
 	"github.com/loft-sh/vcluster/pkg/telemetry"
@@ -164,6 +165,13 @@ func CreateHelm(ctx context.Context, options *CreateOptions, globalFlags *flags.
 		return fmt.Errorf("get current helm release: %w", err)
 	}
 
+	_, err = cmd.kubeClient.CoreV1().Services(globalFlags.Namespace).Get(ctx, platformclihelper.DefaultPlatformServiceName, metav1.GetOptions{})
+	if err == nil {
+		return fmt.Errorf("a vCluster platform installation exists in the namespace '%s'. Aborting install", globalFlags.Namespace)
+	} else if !kerrors.IsNotFound(err) {
+		return fmt.Errorf("get platform service: %w", err)
+	}
+
 	// check if vcluster already exists
 	if !cmd.Upgrade {
 		if isVClusterDeployed(release) {

pkg/platform/clihelper/clihelper.go

@@ -59,6 +59,8 @@ const LoftRouterDomainSecret = "loft-router-domain"
 
 const DefaultPlatformNamespace = "vcluster-platform"
 
+const DefaultPlatformServiceName = "loft"
+
 const defaultTimeout = 10 * time.Minute
 
 const timeoutEnvVariable = "LOFT_TIMEOUT"