[FSTORE-1857] Enable get feature vector for spine group v4.5 (#660) (#662)

* [FSTORE-1857] Enable get feature vector for spine group (#660)

* Enable get feature vector for spine group

* style fix

* style fix

* pump version to 4.5.0-rc5

Author: kennethmhc

java/beam/pom.xml

@@ -5,7 +5,7 @@
   <parent>
     <artifactId>hsfs-parent</artifactId>
     <groupId>com.logicalclocks</groupId>
-    <version>4.5.0-RC4</version>
+    <version>4.5.0-RC5</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 

java/flink/pom.xml

@@ -5,7 +5,7 @@
   <parent>
     <artifactId>hsfs-parent</artifactId>
     <groupId>com.logicalclocks</groupId>
-    <version>4.5.0-RC4</version>
+    <version>4.5.0-RC5</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 

java/hsfs/pom.xml

@@ -5,7 +5,7 @@
   <parent>
     <artifactId>hsfs-parent</artifactId>
     <groupId>com.logicalclocks</groupId>
-    <version>4.5.0-RC4</version>
+    <version>4.5.0-RC5</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 

java/pom.xml

@@ -7,7 +7,7 @@
     <groupId>com.logicalclocks</groupId>
     <artifactId>hsfs-parent</artifactId>
     <packaging>pom</packaging>
-    <version>4.5.0-RC4</version>
+    <version>4.5.0-RC5</version>
     <modules>
         <module>hsfs</module>
         <module>spark</module>

java/spark/pom.xml

@@ -22,7 +22,7 @@
     <parent>
         <artifactId>hsfs-parent</artifactId>
         <groupId>com.logicalclocks</groupId>
-        <version>4.5.0-RC4</version>
+        <version>4.5.0-RC5</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 

python/hopsworks_common/version.py

@@ -14,4 +14,4 @@
 #   limitations under the License.
 #
 
-__version__ = "4.5.0rc4"
+__version__ = "4.5.0rc5"

python/hsfs/core/vector_server.py

@@ -1931,6 +1931,7 @@ def _all_feature_groups_online(self) -> bool:
         """True if all feature groups in the feature view are online."""
         if self.__all_feature_groups_online is None:
             self.__all_feature_groups_online = all(
-                fg.online_enabled for fg in self._parent_feature_groups
+                fg.online_enabled
+                for fg in self._parent_feature_groups if fg.id not in self._skip_fg_ids
             )
         return self.__all_feature_groups_online

python/hsfs/feature_group.py

@@ -1907,6 +1907,11 @@ def feature_store(self) -> feature_store_mod.FeatureStore:
     def feature_store(self, feature_store: feature_store_mod.FeatureStore) -> None:
         self._feature_store = feature_store
 
+    @property
+    def id(self) -> Optional[int]:
+        """Feature group id."""
+        return self._id
+
     @property
     def name(self) -> Optional[str]:
         """Name of the feature group."""
@@ -4584,7 +4589,8 @@ def __init__(
                 great_expectations.core.ExpectationSuite,
             ]
         ] = None,
-        online_enabled: bool = False,
+        # spine groups are online enabled by default such that feature_view.get_feature_vector can be used
+        online_enabled: bool = True,
         href: Optional[str] = None,
         online_topic_name: Optional[str] = None,
         topic_name: Optional[str] = None,
@@ -4773,4 +4779,5 @@ def to_dict(self) -> Dict[str, Any]:
             "spine": True,
             "topicName": self.topic_name,
             "deprecated": self.deprecated,
+            "onlineEnabled": self._online_enabled,
         }

python/hsfs/feature_view.py

@@ -4248,14 +4248,21 @@ def feature_logging(self) -> Optional[FeatureLogging]:
             self._feature_logging = self._feature_view_engine.get_feature_logging(self)
         return self._feature_logging
 
+    def _get_spine_fg_ids(self) -> List[feature_group.SpineGroup]:
+        return [fg.id for fg in self.query.featuregroups if isinstance(fg, feature_group.SpineGroup)]
+
+    def _get_skip_fg_ids(self) -> Set[int]:
+        embedding_fg_ids = [fg.id for fg in self._get_embedding_fgs()]
+        return set(embedding_fg_ids + self._get_spine_fg_ids())
+
     @property
     def _vector_server(self) -> vector_server.VectorServer:
         if not self.__vector_server:
             self.__vector_server = vector_server.VectorServer(
                 feature_store_id=self._featurestore_id,
                 features=self._features,
                 serving_keys=self._serving_keys,
-                skip_fg_ids=set([fg.id for fg in self._get_embedding_fgs()]),
+                skip_fg_ids=self._get_skip_fg_ids(),
                 feature_view_name=self._name,
                 feature_view_version=self._version,
                 feature_store_name=self._feature_store_name,
@@ -4269,7 +4276,7 @@ def _batch_scoring_server(self) -> vector_server.VectorServer:
                 feature_store_id=self._featurestore_id,
                 features=self._features,
                 serving_keys=self._serving_keys,
-                skip_fg_ids=set([fg.id for fg in self._get_embedding_fgs()]),
+                skip_fg_ids=self._get_skip_fg_ids(),
                 feature_view_name=self._name,
                 feature_view_version=self._version,
                 feature_store_name=self._feature_store_name,

utils/java/pom.xml

@@ -5,7 +5,7 @@
 
     <groupId>com.logicalclocks</groupId>
     <artifactId>hsfs-utils</artifactId>
-    <version>4.5.0-RC4</version>
+    <version>4.5.0-RC5</version>
 
     <properties>
         <hops.version>3.2.0.0-SNAPSHOT</hops.version>