Skip to content

Commit 1cb425c

Browse files
javierdlrmclaude
andcommitted
[FSTORE-1412][Append] Map legacy stddev key to std_dev in stats constructors
After the stddev -> std_dev rename, backend payloads and older callers still pass the lowercase `stddev` key, which fell into **kwargs and left std_dev as None — breaking transformation functions that read statistics.<feature>.stddev. Accept the legacy `stddev` key in both FeatureDescriptiveStatistics and FeatureTransformationStatistics constructors (std_dev takes precedence). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent da74d8b commit 1cb425c

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

python/hsfs/core/feature_descriptive_statistics.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,9 @@ def __init__(
8686
self._max = max
8787
self._sum = sum
8888
self._mean = mean
89-
self._std_dev = std_dev
89+
# Accept the legacy lowercase ``stddev`` key (e.g. from backend payloads
90+
# or older callers) so the rename to ``std_dev`` stays backward compatible.
91+
self._std_dev = std_dev if std_dev is not None else kwargs.get("stddev")
9092
self._percentiles = percentiles
9193
self._distinctness = distinctness
9294
self._entropy = entropy

python/hsfs/transformation_statistics.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,9 @@ def __init__(
6565
self._max = max
6666
self._sum = sum
6767
self._mean = mean
68-
self._std_dev = std_dev
68+
# Accept the legacy lowercase ``stddev`` key (e.g. from backend payloads
69+
# or older callers) so the rename to ``std_dev`` stays backward compatible.
70+
self._std_dev = std_dev if std_dev is not None else kwargs.get("stddev")
6971
self._percentiles = percentiles
7072
self._distinctness = distinctness
7173
self._entropy = entropy

0 commit comments

Comments
 (0)