Skip to content

Commit b8a9d13

Browse files
authored
chore: npm publication (#2688)
* chore: npm publication Fixing npm publication and warnings * Upgrade workflow to use trusted publishing https://docs.npmjs.com/trusted-publishers * bump node js to 24 To avoid having to reinstall npm in pre-release for npmjs trusted publishers
1 parent 37c6c1e commit b8a9d13

File tree

19 files changed

+36
-33
lines changed

19 files changed

+36
-33
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ on:
1515
type: string
1616

1717
env:
18-
NODE_JS: "22"
18+
NODE_JS: "24"
1919

2020
jobs:
2121
check:

.github/workflows/pre-release.yml

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,27 +2,29 @@ on:
22
workflow_dispatch:
33

44
env:
5-
NODE_JS: "22"
5+
NODE_JS: "24"
6+
7+
permissions:
8+
id-token: write # Required for npmjs' OIDC
9+
contents: read
610

711
jobs:
812
pre-release:
913
name: pre-release
1014
runs-on: ubuntu-latest
1115
if: github.event_name == 'workflow_dispatch'
1216
steps:
13-
- uses: actions/checkout@v3
14-
with:
17+
- uses: actions/checkout@v4
18+
with:
1519
repository: waku-org/js-waku
16-
17-
- uses: actions/setup-node@v3
20+
21+
- uses: actions/setup-node@v4
1822
with:
1923
node-version: ${{ env.NODE_JS }}
2024
registry-url: "https://registry.npmjs.org"
21-
25+
2226
- run: npm install
23-
27+
2428
- run: npm run build
25-
29+
2630
- run: npm run publish -- --tag next
27-
env:
28-
NODE_AUTH_TOKEN: ${{ secrets.NPM_JS_WAKU_PUBLISH }}

.github/workflows/test-node.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ on:
2424
default: false
2525

2626
env:
27-
NODE_JS: "22"
27+
NODE_JS: "24"
2828
# Ensure test type conditions remain consistent.
2929
WAKU_SERVICE_NODE_PARAMS: ${{ (inputs.test_type == 'go-waku-master') && '--min-relay-peers-to-publish=0' || '' }}
3030
DEBUG: ${{ inputs.debug }}
@@ -42,7 +42,7 @@ jobs:
4242
checks: write
4343
steps:
4444
- uses: actions/checkout@v3
45-
with:
45+
with:
4646
repository: waku-org/js-waku
4747

4848
- name: Remove unwanted software
@@ -62,7 +62,7 @@ jobs:
6262

6363
- name: Merge allure reports
6464
if: always() && env.ALLURE_REPORTS == 'true'
65-
run: node ci/mergeAllureResults.cjs
65+
run: node ci/mergeAllureResults.cjs
6666

6767
- name: Get allure history
6868
if: always() && env.ALLURE_REPORTS == 'true'
@@ -125,4 +125,4 @@ jobs:
125125
echo "## Run Information" >> $GITHUB_STEP_SUMMARY
126126
echo "- **NWAKU**: ${{ env.WAKUNODE_IMAGE }}" >> $GITHUB_STEP_SUMMARY
127127
echo "## Test Results" >> $GITHUB_STEP_SUMMARY
128-
echo "Allure report will be available at: https://waku-org.github.io/allure-jswaku/${{ github.run_number }}" >> $GITHUB_STEP_SUMMARY
128+
echo "Allure report will be available at: https://waku-org.github.io/allure-jswaku/${{ github.run_number }}" >> $GITHUB_STEP_SUMMARY

.github/workflows/test-reliability.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ on:
1818
- all
1919

2020
env:
21-
NODE_JS: "22"
21+
NODE_JS: "24"
2222

2323
jobs:
2424
test:
@@ -34,7 +34,7 @@ jobs:
3434
if: ${{ github.event.inputs.test_type == 'all' }}
3535
steps:
3636
- uses: actions/checkout@v3
37-
with:
37+
with:
3838
repository: waku-org/js-waku
3939

4040
- name: Remove unwanted software
@@ -74,7 +74,7 @@ jobs:
7474
if: ${{ github.event.inputs.test_type != 'all' }}
7575
steps:
7676
- uses: actions/checkout@v3
77-
with:
77+
with:
7878
repository: waku-org/js-waku
7979

8080
- name: Remove unwanted software

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,5 +78,6 @@
7878
"*.{ts,js}": [
7979
"eslint --fix"
8080
]
81-
}
81+
},
82+
"version": ""
8283
}

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"homepage": "https://github.com/waku-org/js-waku/tree/master/packages/core#readme",
2929
"repository": {
3030
"type": "git",
31-
"url": "https://github.com/waku-org/js-waku.git"
31+
"url": "git+https://github.com/waku-org/js-waku.git"
3232
},
3333
"bugs": {
3434
"url": "https://github.com/waku-org/js-waku/issues"

packages/discovery/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"homepage": "https://github.com/waku-org/js-waku/tree/master/packages/discovery#readme",
1616
"repository": {
1717
"type": "git",
18-
"url": "https://github.com/waku-org/js-waku.git"
18+
"url": "git+https://github.com/waku-org/js-waku.git"
1919
},
2020
"bugs": {
2121
"url": "https://github.com/waku-org/js-waku/issues"

packages/enr/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"homepage": "https://github.com/waku-org/js-waku/tree/master/packages/enr#readme",
1616
"repository": {
1717
"type": "git",
18-
"url": "https://github.com/waku-org/js-waku.git"
18+
"url": "git+https://github.com/waku-org/js-waku.git"
1919
},
2020
"bugs": {
2121
"url": "https://github.com/waku-org/js-waku/issues"

packages/interfaces/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"homepage": "https://github.com/waku-org/js-waku/tree/master/packages/interfaces#readme",
1616
"repository": {
1717
"type": "git",
18-
"url": "https://github.com/waku-org/js-waku.git"
18+
"url": "git+https://github.com/waku-org/js-waku.git"
1919
},
2020
"bugs": {
2121
"url": "https://github.com/waku-org/js-waku/issues"

packages/message-encryption/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
"homepage": "https://github.com/waku-org/js-waku/tree/master/packages/message-encryption#readme",
3737
"repository": {
3838
"type": "git",
39-
"url": "https://github.com/waku-org/js-waku.git"
39+
"url": "git+https://github.com/waku-org/js-waku.git"
4040
},
4141
"bugs": {
4242
"url": "https://github.com/waku-org/js-waku/issues"

0 commit comments

Comments
 (0)