Skip to content

chore: enforce method access order#2587

Closed
weboko wants to merge 2 commits into
masterfrom
codex/add-eslint-rule-for-method-order
Closed

chore: enforce method access order#2587
weboko wants to merge 2 commits into
masterfrom
codex/add-eslint-rule-for-method-order

Conversation

@weboko

@weboko weboko commented Aug 21, 2025

Copy link
Copy Markdown
Collaborator

Summary

  • enforce static/public/private member ordering via ESLint
  • reorder methods to satisfy new access order rule

Testing

  • npm run check (fails: Cannot find module '@waku/interfaces' during tsc)
  • npm test (fails: Karma test runner / TypeScript errors)

https://chatgpt.com/codex/tasks/task_e_68a636ec1adc8331af48ee7c78edd143

@weboko
weboko requested a review from a team as a code owner August 21, 2025 09:57
@github-actions

Copy link
Copy Markdown

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 70.4 KB (-0.06% 🔽) 1.5 s (-0.06% 🔽) 1.1 s (-32.71% 🔽) 2.5 s
Waku Simple Light Node 121.87 KB (+0.07% 🔺) 2.5 s (+0.07% 🔺) 1.9 s (+75.59% 🔺) 4.4 s
ECIES encryption 20.8 KB (-7.63% 🔽) 417 ms (-7.63% 🔽) 629 ms (+11.49% 🔺) 1.1 s
Symmetric encryption 20.3 KB (-7.54% 🔽) 407 ms (-7.54% 🔽) 487 ms (-20.42% 🔽) 893 ms
DNS discovery 51.57 KB (0%) 1.1 s (0%) 719 ms (-4.64% 🔽) 1.8 s
Peer Exchange discovery 52.33 KB (+0.08% 🔺) 1.1 s (+0.08% 🔺) 1.2 s (+27.35% 🔺) 2.2 s
Peer Cache Discovery 46.11 KB (0%) 923 ms (0%) 1.2 s (+28.39% 🔺) 2.1 s
Privacy preserving protocols 53.59 KB (-0.07% 🔽) 1.1 s (-0.07% 🔽) 1.1 s (+12.38% 🔺) 2.1 s
Waku Filter 55.32 KB (-0.01% 🔽) 1.2 s (-0.01% 🔽) 999 ms (+14.48% 🔺) 2.2 s
Waku LightPush 53.05 KB (+0.28% 🔺) 1.1 s (+0.28% 🔺) 972 ms (+9.17% 🔺) 2.1 s
History retrieval protocols 59.34 KB (+0.11% 🔺) 1.2 s (+0.11% 🔺) 1.1 s (+9.87% 🔺) 2.3 s
Deterministic Message Hashing 28.41 KB (+0.08% 🔺) 569 ms (+0.08% 🔺) 566 ms (-1.57% 🔽) 1.2 s

@weboko weboko closed this Oct 7, 2025
@weboko
weboko deleted the codex/add-eslint-rule-for-method-order branch October 7, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant