fix: admin API peer shards field from metadata protocol

Store and return peer shard info from metadata protocol exchange instead
of only checking ENR records.

Author: MorganaFuture

waku/node/peer_manager/peer_manager.nim

@@ -658,6 +658,15 @@ proc onPeerMetadata(pm: PeerManager, peerId: PeerId) {.async.} =
         $clusterId
       break guardClauses
 
+    # Store the shard information from metadata in the peer store
+    if pm.switch.peerStore.peerExists(peerId):
+      var peerInfo = pm.switch.peerStore.getPeer(peerId)
+      peerInfo.shards = metadata.shards.mapIt(it.uint16)
+      # Note: We don't need to call updatePeerInfo since we modified the reference directly
+      debug "Updated peer shards from metadata", 
+        peerId = peerId, 
+        shards = peerInfo.shards
+
     return
 
   info "disconnecting from peer", peerId = peerId, reason = reason

waku/waku_core/peers.nim

@@ -48,6 +48,7 @@ type RemotePeerInfo* = ref object
   addrs*: seq[MultiAddress]
   enr*: Option[enr.Record]
   protocols*: seq[string]
+  shards*: seq[uint16]
 
   agent*: string
   protoVersion*: string
@@ -73,6 +74,7 @@ proc init*(
     addrs: seq[MultiAddress] = @[],
     enr: Option[enr.Record] = none(enr.Record),
     protocols: seq[string] = @[],
+    shards: seq[uint16] = @[],
     publicKey: crypto.PublicKey = crypto.PublicKey(),
     agent: string = "",
     protoVersion: string = "",
@@ -88,6 +90,7 @@ proc init*(
     addrs: addrs,
     enr: enr,
     protocols: protocols,
+    shards: shards,
     publicKey: publicKey,
     agent: agent,
     protoVersion: protoVersion,
@@ -105,9 +108,10 @@ proc init*(
     addrs: seq[MultiAddress] = @[],
     enr: Option[enr.Record] = none(enr.Record),
     protocols: seq[string] = @[],
+    shards: seq[uint16] = @[],
 ): T {.raises: [Defect, ResultError[cstring], LPError].} =
   let peerId = PeerID.init(peerId).tryGet()
-  RemotePeerInfo(peerId: peerId, addrs: addrs, enr: enr, protocols: protocols)
+  RemotePeerInfo(peerId: peerId, addrs: addrs, enr: enr, protocols: protocols, shards: shards)
 
 ## Parse
 
@@ -327,6 +331,7 @@ converter toRemotePeerInfo*(peerInfo: PeerInfo): RemotePeerInfo =
     addrs: peerInfo.listenAddrs,
     enr: none(enr.Record),
     protocols: peerInfo.protocols,
+    shards: @[],
     agent: peerInfo.agentVersion,
     protoVersion: peerInfo.protoVersion,
     publicKey: peerInfo.publicKey,
@@ -363,6 +368,9 @@ proc getAgent*(peer: RemotePeerInfo): string =
   return peer.agent
 
 proc getShards*(peer: RemotePeerInfo): seq[uint16] =
+  if peer.shards.len > 0:
+    return peer.shards
+  
   if peer.enr.isNone():
     return @[]