Skip to content

Commit eecd248

Browse files
NagyZoltanPeterIvansete-status
authored andcommitted
Store/Legacy store close connections
1 parent 2771cef commit eecd248

File tree

4 files changed

+14
-0
lines changed

4 files changed

+14
-0
lines changed

waku/waku_store/client.nim

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ proc sendStoreRequest(
2525
): Future[StoreQueryResult] {.async, gcsafe.} =
2626
var req = request
2727

28+
defer:
29+
await connection.closeWithEof()
30+
2831
if req.requestId == "":
2932
req.requestId = generateRequestId(self.rng)
3033

waku/waku_store/protocol.nim

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,10 @@ proc initProtocolHandler(self: WakuStore) =
9292
var successfulQuery = false ## only consider the correct queries in metrics
9393
var resBuf: StoreResp
9494
var queryDuration: float
95+
96+
defer:
97+
await conn.closeWithEof()
98+
9599
self.requestRateLimiter.checkUsageLimit(WakuStoreCodec, conn):
96100
let readRes = catch:
97101
await conn.readLp(DefaultMaxRpcSize.int)

waku/waku_store_legacy/client.nim

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ proc sendHistoryQueryRPC(
4343

4444
let connection = connOpt.get()
4545

46+
defer:
47+
await connection.closeWithEof()
48+
4649
let requestId =
4750
if req.requestId != "":
4851
req.requestId

waku/waku_store_legacy/protocol.nim

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,10 @@ proc initProtocolHandler(ws: WakuStore) =
114114
var successfulQuery = false ## only consider the correct queries in metrics
115115
var resBuf: StoreResp
116116
var queryDuration: float
117+
118+
defer:
119+
await conn.closeWithEof()
120+
117121
ws.requestRateLimiter.checkUsageLimit(WakuLegacyStoreCodec, conn):
118122
let readRes = catch:
119123
await conn.readLp(DefaultMaxRpcSize.int)

0 commit comments

Comments
 (0)