Skip to content

Commit 29a6c15

Browse files
committed
fix: empty responses should not generate an error
1 parent e0ccdbe commit 29a6c15

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

waku/v2/protocol/store/waku_store_client.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,9 +206,10 @@ func (store *WakuStore) queryFrom(ctx context.Context, q *pb.HistoryQuery, selec
206206
}
207207

208208
if historyResponseRPC.Response == nil {
209-
logger.Error("empty response")
210-
metrics.RecordStoreError(store.ctx, "emptyRpcResponseFailure")
211-
return nil, ErrEmptyResponse
209+
// Empty response
210+
return &pb.HistoryResponse{
211+
PagingInfo: &pb.PagingInfo{},
212+
}, nil
212213
}
213214

214215
metrics.RecordMessage(ctx, "retrieved", len(historyResponseRPC.Response.Messages))

waku/v2/protocol/store/waku_store_common.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ var (
4141
ErrFailedQuery = errors.New("failed to resolve the query")
4242

4343
ErrFutureMessage = errors.New("message timestamp in the future")
44-
45-
ErrEmptyResponse = errors.New("empty store response")
4644
)
4745

4846
type WakuSwap interface {

0 commit comments

Comments
 (0)