bug: Rendezvous peer discovery is not functioning

[AYAHASSAN287]

Problem

Rendezvous peer discovery is not functioning as expected.
When running the rendezvous tests, nodes fail to discover peers through the rendezvous mechanism, which contradicts the assumptions outlined in Rendezvous FURPS spec.

To reproduce

Use the test branch:
logos-messaging/logos-messaging-interop-tests#132

and check test test_basic_rendezvous_register_and_discover

Expected behavior

Node3 should discover at least one peer via rendezvous.

Actual behavior

Node3 discovers zero peers, causing the assertion to fail.

Logs / Screenshots

Example test failure:

 ``` Node3 peers count is : [] AssertionError: No peers discovered via Rendezvous ``` 

[SionoiS]

In a bootstrapping scenario the new node knows the boot node, it is the first node it connects to. The problem I see is that we have to know the protocols the boot node supports before selecting it for rendezvous since the rendezvous code is triggered at startup.

We could delay the trigger but it kinda defeat the purpose.

Is there a way to add peers WITH protocols to the peer manager BEFORE connecting? @Ivansete-status

cc @jm-clius

[jm-clius]

Is there a way to add peers WITH protocols to the peer manager BEFORE connecting?

I haven't looked at the code in detail, but I'm not sure I see why this would be necessary? Isn't the trigger exactly to see periodically if we have rendezvous peers available, register at those rdv points and discover new nodes from those same points. In other words, if the first trigger fails because we don't know that the bootstrap nodes support rdv yet, surely the next periodic call will succeed because by then we have exchanged this information via identify?

[SionoiS]

Is there a way to add peers WITH protocols to the peer manager BEFORE connecting?

I haven't looked at the code in detail, but I'm not sure I see why this would be necessary? Isn't the trigger exactly to see periodically if we have rendezvous peers available, register at those rdv points and discover new nodes from those same points. In other words, if the first trigger fails because we don't know that the bootstrap nodes support rdv yet, surely the next periodic call will succeed because by then we have exchanged this information via identify?

There is no periodic call. We could add that I guess...

[jm-clius]

Ah, I've read the spec again. I see what you mean - we do periodic registrations, but not periodic discovery. RDV is meant for fast initial discovery. Yes, in my mind, discovery should be called periodically until such time as we have some indication that we have "enough" peers. Also cc @chaitanyaprem as this relates to our general discovery requirements.