Skip to content

bug: extension for dynamic libraries is incorrect in mac #3633

@richard-ramos

Description

@richard-ramos

https://github.com/waku-org/nwaku/blob/9808e205af522989cc6888c12e6656df47e0da48/Makefile#L427-L435

In mac it should be .dylib... maybe something like this should do the trick (copied from status-go makefile)

ifeq ($(OS),Windows_NT)     # is Windows_NT on XP, 2000, 7, Vista, 10...
 	detected_OS := Windows
else
 	detected_OS := $(strip $(shell uname))
endif

ifeq ($(detected_OS),Darwin)
 	LIBWAKU_EXT := dylib
else ifeq ($(detected_OS),Windows)
 	LIBWAKU_EXT := dll
else
 	LIBWAKU_EXT := so
endif

ifeq ($(STATIC), 1) 
	echo -e $(BUILD_MSG) "build/[email protected]" && $(ENV_SCRIPT) nim libwakuStatic $(NIM_PARAMS) waku.nims 
else
	echo -e $(BUILD_MSG) "build/$@.$(LIBWAKU_EXT)" && $(ENV_SCRIPT) nim libwakuDynamic $(NIM_PARAMS) waku.nims 
endif 

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

Status

Priority

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions