Skip to content

watched file might be removed while trying to read #269

Open
@kares

Description

@kares

the plugin in certain rare cases runs into a concurrency problem, while trying to read :

[ERROR][filewatch.readmode.handlers.readfile] controlled_read: general error reading file {
"path"=>"/logstash/data/path/to.json", 
"error"=>"#<NoMethodError: undefined method `increment_position' for nil:NilClass>", 
"backtrace"=>[
"/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-input-file-4.1.11/lib/filewatch/sincedb_collection.rb:144:in `increment'", 
"/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-input-file-4.1.11/lib/filewatch/read_mode/handlers/read_file.rb:41:in `block in controlled_read'", 
"org/jruby/RubyArray.java:1792:in `each'", 
"/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-input-file-4.1.11/lib/filewatch/read_mode/handlers/read_file.rb:37:in `block in controlled_read'", 
"/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-input-file-4.1.11/lib/filewatch/read_mode/handlers/read_file.rb:32:in `controlled_read'", 
"/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-input-file-4.1.11/lib/filewatch/read_mode/handlers/read_file.rb:11:in `block in handle_specifically'", 
"org/jruby/RubyKernel.java:1425:in `loop'", "/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/logstash-input-file-4.1.11/lib/filewatch/read_mode/handlers/read_file.rb:8:in `handle_specifically'"
]}

... the watched file entry got removed in this case but the plugin still triggered a read attempt.
we need to investigate what all potential consequences are around such issues (e.g. if they could cause event loss from other parts).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions