Skip to content

bug: handleSignInCallback fails on RoadRunner (SERVER_NAME not set) #22

Description

@LeoAdamek

Describe the bug

The following checks fail on applications using RoadRunner (e.g. via Laravel Octane), as RoadRunner does not set a SERVER_NAME property in the _SERVER super-global.

https://github.com/logto-io/php/blob/master/src/LogtoClient.php#L302-L307

This causes the Logto SDK to erroneously block the sign-in.

Expected behavior

User sign in proceeds as normal, with state being checked against the session, and code being used to request an auth token from Logto.

If the http host is to be checked, it should be parsed from $_SERVER['REQUEST_URI'] or allow for an override to be set at some point in the API call.

e.g.

parse_url($signInSession->redirectUri, PHP_URL_HOST) !== parse_url($_SERVER['REQUEST_URI'], PHP_URL_HOST)

How to reproduce?

Attempt to authenticate in an environment where $_SERVER['SERVER_NAME'] is undefined. (perhaps by deliberately deleting this config key before calling handleSignInCallback()

Environment

Self-hosted (Docker image)

Screenshots

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions