Skip to content

Commit 3547207

Browse files
authored
Consolidating images and artifacts (llm-d#2048)
* stop publishing a -dev chart Signed-off-by: ahg-g <ahg@google.com> * publish llm-d-router-disagg-sidecar and llm-d-router-endpoint-picker latest images on each commit Signed-off-by: ahg-g <ahg@google.com> * switch to use llm-d-router-endpoint-picker and llm-d-router-disagg-sidecar with tag latest as the default instead of the -dev suffixed ones Signed-off-by: ahg-g <ahg@google.com> * changed the latest tag with main Signed-off-by: ahg-g <ahg@google.com> * revert to using dev tag for e2e tests Signed-off-by: ahg-g <ahg@google.com> --------- Signed-off-by: ahg-g <ahg@google.com>
1 parent 4a6c416 commit 3547207

8 files changed

Lines changed: 28 additions & 7 deletions

File tree

.github/actions/docker-build-and-push/action.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,10 @@ inputs:
3333
required: false
3434
description: Git commit SHA to embed via COMMIT_SHA build arg
3535
default: ''
36+
additional-tags:
37+
required: false
38+
description: Additional image tags to push
39+
default: ''
3640
runs:
3741
using: "composite"
3842
steps:
@@ -58,6 +62,7 @@ runs:
5862
${{ inputs.registry }}/${{ inputs.image-name }}:${{ inputs.tag }}
5963
${{ inputs.push == 'true' && inputs.prerelease != 'true' && format('{0}/{1}:latest', inputs.registry, inputs.image-name) || '' }}
6064
${{ inputs.commit-sha != '' && format('{0}/{1}:{2}', inputs.registry, inputs.image-name, inputs.commit-sha) || '' }}
65+
${{ inputs.additional-tags }}
6166
build-args: |
6267
LDFLAGS=-s -w
6368
COMMIT_SHA=${{ inputs.commit-sha || 'unknown' }}

.github/actions/helm-build-and-push/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ inputs:
1212
required: false
1313
default: ''
1414
epp_image_repository:
15-
description: 'EPP image repository name (e.g. llm-d-router-endpoint-picker or llm-d-router-endpoint-picker-dev)'
15+
description: 'EPP image repository name (e.g. llm-d-router-endpoint-picker)'
1616
required: false
1717
default: 'llm-d-router-endpoint-picker'
1818
runs:

.github/workflows/ci-build-images.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,14 @@ on:
1919
required: false
2020
type: string
2121
default: ''
22+
epp-additional-tags:
23+
required: false
24+
type: string
25+
default: ''
26+
sidecar-additional-tags:
27+
required: false
28+
type: string
29+
default: ''
2230

2331
permissions:
2432
contents: read
@@ -60,6 +68,7 @@ jobs:
6068
prerelease: ${{ inputs.prerelease }}
6169
commit-sha: ${{ github.sha }}
6270
push: 'true'
71+
additional-tags: ${{ inputs.epp-additional-tags }}
6372

6473
build-sidecar:
6574
runs-on: ubuntu-latest
@@ -93,6 +102,7 @@ jobs:
93102
prerelease: ${{ inputs.prerelease }}
94103
commit-sha: ${{ github.sha }}
95104
push: 'true'
105+
additional-tags: ${{ inputs.sidecar-additional-tags }}
96106

97107
push-helm-charts:
98108
needs: [build-epp, build-sidecar]

.github/workflows/ci-dev.yaml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ jobs:
1919
outputs:
2020
epp_name: ${{ steps.version.outputs.epp_name }}
2121
sidecar_name: ${{ steps.version.outputs.sidecar_name }}
22+
epp_base_name: ${{ steps.version.outputs.epp_base_name }}
23+
sidecar_base_name: ${{ steps.version.outputs.sidecar_base_name }}
2224
tag: ${{ steps.tag.outputs.tag }}
2325
steps:
2426
- name: Set image names
@@ -27,6 +29,8 @@ jobs:
2729
repo="${GITHUB_REPOSITORY##*/}"
2830
echo "epp_name=${repo}-endpoint-picker-dev" >> "$GITHUB_OUTPUT"
2931
echo "sidecar_name=${repo}-disagg-sidecar-dev" >> "$GITHUB_OUTPUT"
32+
echo "epp_base_name=${repo}-endpoint-picker" >> "$GITHUB_OUTPUT"
33+
echo "sidecar_base_name=${repo}-disagg-sidecar" >> "$GITHUB_OUTPUT"
3034
3135
- name: Set branch name as tag
3236
id: tag
@@ -42,5 +46,7 @@ jobs:
4246
sidecar-image-name: ${{ needs.set-params.outputs.sidecar_name }}
4347
tag: ${{ needs.set-params.outputs.tag }}
4448
prerelease: true
45-
chart-suffix: "-dev"
49+
chart-suffix: ""
50+
epp-additional-tags: ghcr.io/llm-d/${{ needs.set-params.outputs.epp_base_name }}:main
51+
sidecar-additional-tags: ghcr.io/llm-d/${{ needs.set-params.outputs.sidecar_base_name }}:main
4652

config/charts/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ Core settings for the Endpoint Picker Proxy (EPP) container and pod, including s
119119
| `router.epp.replicas` | Number of EPP replicas. Set > 1 to enable multi-replica EPP. | `1` |
120120
| `router.epp.extProcPort` | Port EPP uses for external processing gRPC communication. | `9002` |
121121
| `router.epp.image.registry` | EPP container image registry. | `ghcr.io/llm-d` |
122-
| `router.epp.image.repository` | EPP container image repository. | `llm-d-router-endpoint-picker-dev` |
122+
| `router.epp.image.repository` | EPP container image repository. | `llm-d-router-endpoint-picker` |
123123
| `router.epp.image.tag` | EPP container image tag. | `main` |
124124
| `router.epp.image.pullPolicy` | EPP container image pull policy. | `Always` |
125125
| `router.epp.env` | Extra environment variables for EPP container. | `[]` |

config/charts/routerlib/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ epp:
77
replicas: 1
88
image:
99
registry: ghcr.io/llm-d
10-
repository: llm-d-router-endpoint-picker-dev
10+
repository: llm-d-router-endpoint-picker
1111
tag: main
1212
pullPolicy: Always
1313
extProcPort: 9002

test/perf/config/router-configs/optimized-baseline.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ router:
1111
replicas: 1
1212
image:
1313
registry: ghcr.io/llm-d
14-
repository: llm-d-router-endpoint-picker-dev
14+
repository: llm-d-router-endpoint-picker
1515
tag: main
1616
pullPolicy: Always
1717
flags:

test/perf/run_nightly_perf.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def deploy_epp(ns, chart_path, chart_version, router_config_path, epp_cpu="2", e
118118
release_name = os.path.splitext(os.path.basename(router_config_path))[0]
119119

120120
epp_registry = os.environ.get("EPP_REGISTRY", "ghcr.io/llm-d")
121-
epp_repository = os.environ.get("EPP_REPOSITORY", "llm-d-router-endpoint-picker-dev")
121+
epp_repository = os.environ.get("EPP_REPOSITORY", "llm-d-router-endpoint-picker")
122122
epp_tag = os.environ.get("EPP_TAG", "main")
123123

124124
cpu_limit = double_cpu(epp_cpu)
@@ -657,7 +657,7 @@ def main():
657657
# Resolve relative defaults
658658
default_sim_deploy = os.path.join(script_dir, "config", "llm-d-sim-deployment.yaml")
659659
default_sim_svc = os.path.join(script_dir, "config", "llm-d-sim-service.yaml")
660-
default_router_chart = "oci://ghcr.io/llm-d/charts/llm-d-router-standalone-dev"
660+
default_router_chart = "oci://ghcr.io/llm-d/charts/llm-d-router-standalone"
661661
default_perf_chart = os.path.abspath(os.path.join(script_dir, "..", "..", "..", "..", "inference-perf", "deploy", "inference-perf"))
662662
default_perf_job = os.path.join(script_dir, "config", "shared_prefix_job1.yaml")
663663
default_results_dir = os.path.abspath(os.path.join(script_dir, "results"))

0 commit comments

Comments
 (0)