DateType schema field generates GraphQL type that isn't provided

[Swahvay]

Using the DateType schema field type generates a GraphQL type of Time, but that object is never defined in the schema file.

// foo_schema.ts
const FooSchema = new EntSchema({
  date: DateType({});
}

# schema.gql
type Foo implements Node {
  date: Time!
}

[lolopinto]

there's no scalar Time line in schema.gql?

maybe it somehow is only added if there's a TimestampType type and whatever logic does it doesn't account for DateType. not that big a deal since the schema.gql file is only informative but we should fix to avoid confusion.

[Swahvay]

there's no scalar Time line in schema.gql?

Nope.

not that big a deal since the schema.gql file is only informative

What do you mean by this? I'm using this as my schema definition for a relay app. Is that not the right way to do it?

[lolopinto]

What do you mean by this? I'm using this as my schema definition for a relay app. Is that not the right way to do it?

it's almost certainly right. i just haven't focused on it to be 100% accurate and it's not tested.

usually, i've used it just to spotcheck the schema and then use a tool like get-graphql-schema for relay since that's presumably tested and using the generated GraphQLSchema to derive it.

[Swahvay]

usually, i've used it just to spotcheck the schema and then use a tool like get-graphql-schema for relay since that's presumably tested and using the generated GraphQLSchema to derive it.

I guess I don't follow. Why generate this file, then spot check it against another library that generates the file? Why not just have the ent library call get-graph-schema to generate the file?

[lolopinto]

hmm, it's more like i generate it and then when i make schema changes, i look at this file to see that the changes are what I think they should be

I used to use graphql-js to generate this file but it was slowing down codegen because i had to load node so I switched to generating manually

[lolopinto]

i had #651 a while back to sanitize/as my test but for some reason i abandoned it. would need to redo something like that

[Swahvay]

Hmm, yeah, generating the graphQL does include the scalar Time, but it re-arranges everything so there's basically no way to tell if there were other changes as well. Maybe this could be done as part of a yarn codegen --full or something? That way you would've have to worry about doing it yourself perfectly.

[lolopinto]

what were you doing that it wasn't generating the graphql? I had been trying to repro and I couldn't so good to know that it works now

[Swahvay]

It was generating the graphQL when I ran yarn codegen, but was missing the scalar Time piece. Running get-graph-schema pointed to my local server generates the schema with the missing Time piece.

[lolopinto]

oh, so yarn codegen still not generating it?

[Swahvay]

It's generating the schema.gql file, yes, just not the one line, which caused it to error.

[Swahvay]

This seems to be working now.