fix(perf): speed up overlay open for large entries

Author: lolwierd

CHANGELOG.md

@@ -4,6 +4,13 @@ All notable changes to this project are documented in this file.
 
 ## [Unreleased]
 
+## [0.5.2] - 2026-03-27
+
+### Fixed
+
+- Removed overlay-open stalls caused by formatting and previewing very large clipboard items on the hot path. List titles now scan only a small prefix, inline text preview is excerpted, and inline image preview uses cached thumbnails instead of full image decodes.
+- Opening the overlay no longer triggers redundant search/filter resets when the search state is already at its default.
+
 ## [0.5.1] - 2026-02-24
 
 ### Fixed
@@ -171,7 +178,8 @@ All notable changes to this project are documented in this file.
 - In-app preview toggle (`⌘Y`).
 - Delete/undo workflow (`⌘D` / `⌘Z`).
 
-[Unreleased]: https://github.com/lolwierd/cb-manager/compare/v0.5.1...HEAD
+[Unreleased]: https://github.com/lolwierd/cb-manager/compare/v0.5.2...HEAD
+[0.5.2]: https://github.com/lolwierd/cb-manager/compare/v0.5.1...v0.5.2
 [0.5.1]: https://github.com/lolwierd/cb-manager/compare/v0.5.0...v0.5.1
 [0.5.0]: https://github.com/lolwierd/cb-manager/compare/v0.4.0...v0.5.0
 [0.4.0]: https://github.com/lolwierd/cb-manager/compare/v0.3.0...v0.4.0

Sources/CBManager/ClipboardStore.swift

@@ -113,6 +113,9 @@ struct ClipboardEntry: Identifiable, Hashable, Sendable {
     /// Searching deep into a multi-MB clipboard entry is pointless for
     /// fuzzy matching and extremely expensive.
     private static let searchContentLimit = 500
+    /// Maximum characters to scan when generating a one-line list title.
+    /// The overlay only needs a compact summary, not the full payload.
+    private static let titleLineScanLimit = 512
 
     private static func computeSearchHints(kind: Kind, content: String) -> String {
         var hints: [String] = [kind.rawValue.lowercased()]
@@ -155,10 +158,18 @@ struct ClipboardEntry: Identifiable, Hashable, Sendable {
     }
 
     private static func compactLine(_ text: String, limit: Int) -> String {
-        let oneLine = text
+        let scanEnd = text.index(text.startIndex, offsetBy: titleLineScanLimit, limitedBy: text.endIndex) ?? text.endIndex
+        let truncatedAtSource = scanEnd != text.endIndex
+        let excerpt = String(text[..<scanEnd])
+
+        let oneLine = excerpt
+            .replacingOccurrences(of: "\r\n", with: " ")
             .replacingOccurrences(of: "\n", with: " ")
+            .replacingOccurrences(of: "\r", with: " ")
             .trimmingCharacters(in: .whitespacesAndNewlines)
-        guard oneLine.count > limit else { return oneLine }
+        guard oneLine.count > limit else {
+            return truncatedAtSource ? oneLine + "…" : oneLine
+        }
         return String(oneLine.prefix(limit)) + "…"
     }
 }
@@ -307,8 +318,12 @@ final class ClipboardStore: ObservableObject {
         // Clear stale search state so the overlay opens instantly.
         // Skip reset when re-showing after preview dismiss.
         if resetSearch {
-            query = ""
-            selectedFilter = .all
+            if !query.isEmpty {
+                query = ""
+            }
+            if selectedFilter != .all {
+                selectedFilter = .all
+            }
         }
         overlayPresentedToken = UUID()
     }

Sources/CBManager/Views/SearchOverlayView.swift

@@ -3,6 +3,9 @@ import Carbon
 import SwiftUI
 
 struct SearchOverlayView: View {
+    private static let inlinePreviewCharacterLimit = 12_000
+    private static let metadataScanCharacterLimit = 20_000
+
     @ObservedObject var store: ClipboardStore
     let onClose: () -> Void
     let onConfirm: (ClipboardEntry) -> Void
@@ -220,10 +223,19 @@ struct SearchOverlayView: View {
                         if selectedEntry.kind == .image {
                             imagePreview(for: selectedEntry, availableSize: geometry.size)
                         } else {
-                            Text(selectedEntry.content)
-                                .font(font(for: selectedEntry.kind))
-                                .textSelection(.enabled)
-                                .frame(maxWidth: .infinity, alignment: .topLeading)
+                            VStack(alignment: .leading, spacing: 10) {
+                                Text(overlayPreviewText(for: selectedEntry))
+                                    .font(font(for: selectedEntry.kind))
+                                    .textSelection(.enabled)
+                                    .frame(maxWidth: .infinity, alignment: .topLeading)
+
+                                if isInlinePreviewTruncated(for: selectedEntry) {
+                                    Text("Showing an excerpt here for speed. Use ⌘Y for the full preview.")
+                                        .font(.system(size: 11, weight: .regular, design: .rounded))
+                                        .foregroundStyle(.secondary)
+                                }
+                            }
+                            .frame(maxWidth: .infinity, alignment: .topLeading)
                         }
 
                         Divider().overlay(.white.opacity(0.08))
@@ -257,18 +269,26 @@ struct SearchOverlayView: View {
     @ViewBuilder
     private func imagePreview(for entry: ClipboardEntry, availableSize: CGSize) -> some View {
         if let imagePath = entry.imagePath,
-           let image = NSImage(contentsOfFile: imagePath) {
-            let previewHeight = adaptiveImagePreviewHeight(for: availableSize, imageSize: image.size)
+           let imageSize = ThumbnailCache.imageDimensions(at: imagePath) {
+            let previewHeight = adaptiveImagePreviewHeight(for: availableSize, imageSize: imageSize)
+            let maxPixelSize = max(availableSize.width, availableSize.height) * 2
+            let previewImage = ThumbnailCache.shared.thumbnail(for: imagePath, maxPixelSize: maxPixelSize)
 
             ZStack {
                 RoundedRectangle(cornerRadius: 12, style: .continuous)
                     .fill(.white.opacity(0.05))
 
-                Image(nsImage: image)
-                    .resizable()
-                    .scaledToFit()
-                    .frame(maxWidth: .infinity, maxHeight: .infinity)
-                    .padding(8)
+                if let previewImage {
+                    Image(nsImage: previewImage)
+                        .resizable()
+                        .scaledToFit()
+                        .frame(maxWidth: .infinity, maxHeight: .infinity)
+                        .padding(8)
+                } else {
+                    Text("Image preview unavailable")
+                        .font(.system(size: 12, weight: .regular, design: .rounded))
+                        .foregroundStyle(.secondary)
+                }
             }
             .frame(maxWidth: .infinity)
             .frame(height: previewHeight)
@@ -449,11 +469,6 @@ struct SearchOverlayView: View {
     }
 
     private func metadataRows(for entry: ClipboardEntry, contentForStats: String) -> [(title: String, value: String)] {
-        let chars = contentForStats.count
-        let words = contentForStats
-            .split(whereSeparator: { $0.isWhitespace || $0.isNewline })
-            .count
-
         if entry.kind == .image,
            let imagePath = entry.imagePath,
            let size = ThumbnailCache.imageDimensions(at: imagePath) {
@@ -480,15 +495,50 @@ struct SearchOverlayView: View {
             return rows
         }
 
+        let stats = inlineMetadataStats(for: contentForStats)
         return [
             ("Type", entry.kind.rawValue),
             ("Source", entry.sourceApp ?? "Unknown"),
-            ("Characters", "\(chars)"),
-            ("Words", "\(words)"),
+            ("Characters", stats.characterLabel),
+            ("Words", stats.wordLabel),
             ("Copied", entry.date.formatted(date: .abbreviated, time: .shortened))
         ]
     }
 
+    private func overlayPreviewText(for entry: ClipboardEntry) -> String {
+        let preview = truncatedPrefix(
+            of: entry.content,
+            limit: Self.inlinePreviewCharacterLimit
+        )
+        return preview.text
+    }
+
+    private func isInlinePreviewTruncated(for entry: ClipboardEntry) -> Bool {
+        truncatedPrefix(
+            of: entry.content,
+            limit: Self.inlinePreviewCharacterLimit
+        ).truncated
+    }
+
+    private func inlineMetadataStats(for content: String) -> (characterLabel: String, wordLabel: String) {
+        let preview = truncatedPrefix(
+            of: content,
+            limit: Self.metadataScanCharacterLimit
+        )
+        let characterCount = preview.text.count
+        let wordCount = preview.text
+            .split(whereSeparator: { $0.isWhitespace || $0.isNewline })
+            .count
+
+        let suffix = preview.truncated ? "+" : ""
+        return ("\(characterCount)\(suffix)", "\(wordCount)\(suffix)")
+    }
+
+    private func truncatedPrefix(of text: String, limit: Int) -> (text: String, truncated: Bool) {
+        let end = text.index(text.startIndex, offsetBy: limit, limitedBy: text.endIndex) ?? text.endIndex
+        return (String(text[..<end]), end != text.endIndex)
+    }
+
     private func font(for kind: ClipboardEntry.Kind) -> Font {
         switch kind {
         case .code, .path: