fix: prelaunch test fixes

CAS on local and S3 refs treats expected_commit_id=None as no constraint; CLI status requires an existing repository; the s3 dataset-roots test isolates its worktree.

Author: Lundez

src/fluxel/core/objects/local.py

@@ -130,10 +130,11 @@ def compare_and_set_branch_ref(
         current_token = self.version_token("ref", branch)
         if current_token != expected_version_token:
             return False
-        current_state = self.read_branch_ref(branch)
-        current_commit_id = current_state.commit_id if current_state else None
-        if current_commit_id != expected_commit_id:
-            return False
+        if expected_commit_id is not None:
+            current_state = self.read_branch_ref(branch)
+            current_commit_id = current_state.commit_id if current_state else None
+            if current_commit_id != expected_commit_id:
+                return False
         self.write_branch_ref(branch, commit_id)
         return True
 

src/fluxel/core/objects/s3.py

@@ -225,9 +225,10 @@ def compare_and_set_branch_ref(
         current_version = current.version_token if current else None
         if current_version != expected_version_token:
             return False
-        current_commit_id = current.commit_id if current else None
-        if current_commit_id != expected_commit_id:
-            return False
+        if expected_commit_id is not None:
+            current_commit_id = current.commit_id if current else None
+            if current_commit_id != expected_commit_id:
+                return False
 
         try:
             if expected_version_token is None:

src/fluxel/core/repository.py

@@ -851,7 +851,9 @@ def move_staged(
 def status(
     root: str | Path, *, ref: str | None = None, working_tree: bool = True
 ) -> StageStatus:
-    return open_repository(root).status(ref=ref, working_tree=working_tree)
+    return open_repository(root, must_exist=True).status(
+        ref=ref, working_tree=working_tree
+    )
 
 
 def diff(root: str | Path, from_ref: str, to_ref: str) -> list[DiffEntry]:

tests/test_prelaunch_fixes.py

@@ -62,9 +62,12 @@ def test_s3_atomic_cas_conditional_write(fake_s3_installer) -> None:
     assert updated_state.commit_id == "2" * 64
 
 
-def test_vfs_s3_dataset_roots(fake_s3_installer, tmp_path: Path) -> None:
+def test_vfs_s3_dataset_roots(
+    fake_s3_installer, tmp_path: Path, monkeypatch
+) -> None:
     client = fake_s3_installer({})
     repo_uri = "s3://demo-bucket/repos/remote_demo"
+    monkeypatch.chdir(tmp_path)
 
     (tmp_path / "data.txt").write_text("s3 dataset content")
     assert run_cli(["commit", "--repo", repo_uri, "-m", "remote seed"]) == 0